[Mlir-commits] [mlir] 62851ea - [MLIR] Rename free function `verify` on OffsetSizeAndStrideOpInterface

[Uday Bondhugula]

Author: Uday Bondhugula
Date: 2021-05-05T17:44:15+05:30
New Revision: 62851ea7ea2ca59766daab878c5c68629734cb4d

URL: https://github.com/llvm/llvm-project/commit/62851ea7ea2ca59766daab878c5c68629734cb4d
DIFF: https://github.com/llvm/llvm-project/commit/62851ea7ea2ca59766daab878c5c68629734cb4d.diff

LOG: [MLIR] Rename free function `verify` on OffsetSizeAndStrideOpInterface

Using a free function verify(<Op>) is error prone. Rename it.

Differential Revision: https://reviews.llvm.org/D101886

Added: 
    

Modified: 
    mlir/include/mlir/Interfaces/ViewLikeInterface.h
    mlir/include/mlir/Interfaces/ViewLikeInterface.td
    mlir/lib/Interfaces/ViewLikeInterface.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Interfaces/ViewLikeInterface.h b/mlir/include/mlir/Interfaces/ViewLikeInterface.h
index 434717a6ba88f..60f20432d3c3b 100644
--- a/mlir/include/mlir/Interfaces/ViewLikeInterface.h
+++ b/mlir/include/mlir/Interfaces/ViewLikeInterface.h
@@ -29,7 +29,10 @@ struct Range {
 };
 
 class OffsetSizeAndStrideOpInterface;
-LogicalResult verify(OffsetSizeAndStrideOpInterface op);
+
+namespace detail {
+LogicalResult verifyOffsetSizeAndStrideOp(OffsetSizeAndStrideOpInterface op);
+} // namespace detail
 } // namespace mlir
 
 /// Include the generated interface declarations.

diff  --git a/mlir/include/mlir/Interfaces/ViewLikeInterface.td b/mlir/include/mlir/Interfaces/ViewLikeInterface.td
index 0c1469751ecb9..f94350fe50e31 100644
--- a/mlir/include/mlir/Interfaces/ViewLikeInterface.td
+++ b/mlir/include/mlir/Interfaces/ViewLikeInterface.td
@@ -445,7 +445,8 @@ def OffsetSizeAndStrideOpInterface : OpInterface<"OffsetSizeAndStrideOpInterface
   }];
 
   let verify = [{
-    return ::mlir::verify(::mlir::cast<::mlir::OffsetSizeAndStrideOpInterface>($_op));
+    return ::mlir::detail::verifyOffsetSizeAndStrideOp(
+        ::mlir::cast<::mlir::OffsetSizeAndStrideOpInterface>($_op));
   }];
 }
 

diff  --git a/mlir/lib/Interfaces/ViewLikeInterface.cpp b/mlir/lib/Interfaces/ViewLikeInterface.cpp
index aae84803a91ee..ad2b6b49feb7e 100644
--- a/mlir/lib/Interfaces/ViewLikeInterface.cpp
+++ b/mlir/lib/Interfaces/ViewLikeInterface.cpp
@@ -34,7 +34,8 @@ LogicalResult mlir::verifyListOfOperandsOrIntegers(
   return success();
 }
 
-LogicalResult mlir::verify(OffsetSizeAndStrideOpInterface op) {
+LogicalResult
+mlir::detail::verifyOffsetSizeAndStrideOp(OffsetSizeAndStrideOpInterface op) {
   std::array<unsigned, 3> maxRanks = op.getArrayAttrMaxRanks();
   // Offsets can come in 2 flavors:
   //   1. Either single entry (when maxRanks == 1).