[Mlir-commits] [mlir] 7f7be19 - [mlir] Add notes about using external interface application.
Sean Silva
llvmlistbot at llvm.org
Fri Jun 18 07:42:59 PDT 2021
Author: Sean Silva
Date: 2021-06-18T07:42:47-07:00
New Revision: 7f7be19e6a5e0ebb3af04a624996fbc7cd06f209
URL: https://github.com/llvm/llvm-project/commit/7f7be19e6a5e0ebb3af04a624996fbc7cd06f209
DIFF: https://github.com/llvm/llvm-project/commit/7f7be19e6a5e0ebb3af04a624996fbc7cd06f209.diff
LOG: [mlir] Add notes about using external interface application.
Differential Revision: https://reviews.llvm.org/D104489
Added:
Modified:
mlir/docs/Interfaces.md
Removed:
################################################################################
diff --git a/mlir/docs/Interfaces.md b/mlir/docs/Interfaces.md
index bcc9938df8a11..9943019a10f7f 100644
--- a/mlir/docs/Interfaces.md
+++ b/mlir/docs/Interfaces.md
@@ -292,6 +292,12 @@ int main() {
}
```
+Note: It is strongly encouraged to only use this mechanism if you "own" the
+interface being externally applied. This prevents a situation where neither the
+owner of the dialect containing the object nor the owner of the interface are
+aware of an interface implementation, which can lead to duplicate or
+diverging implementations.
+
#### Dialect Fallback for OpInterface
Some dialects have an open ecosystem and don't register all of the possible
More information about the Mlir-commits
mailing list