[Mlir-commits] [mlir] d3c895a - [mlir-lsp-server] Add an explicit blurb on where to send code contributions.

[River Riddle]

Author: River Riddle
Date: 2021-06-16T18:22:01-07:00
New Revision: d3c895a870d324d1fdfc177104785d551e5993f7

URL: https://github.com/llvm/llvm-project/commit/d3c895a870d324d1fdfc177104785d551e5993f7
DIFF: https://github.com/llvm/llvm-project/commit/d3c895a870d324d1fdfc177104785d551e5993f7.diff

LOG: [mlir-lsp-server] Add an explicit blurb on where to send code contributions.

When the vscode extension is published, it may be unclear how to contribute improvements to the extension. This revision makes it clear that contributions should follow the traditional LLVM guidelines.

Added: 
    

Modified: 
    mlir/docs/Tools/MLIRLSP.md

Removed: 
    


################################################################################
diff  --git a/mlir/docs/Tools/MLIRLSP.md b/mlir/docs/Tools/MLIRLSP.md
index 5627cae22e6e..3cd66b3aeee8 100644
--- a/mlir/docs/Tools/MLIRLSP.md
+++ b/mlir/docs/Tools/MLIRLSP.md
@@ -166,8 +166,13 @@ settings of this extension.
 
 This extension is actively developed within the
 [LLVM monorepo](https://github.com/llvm/llvm-project/tree/main/mlir/utils/vscode),
-at `mlir/utils/vscode`. When developing or deploying this extension within the
-LLVM monorepo, a few extra setup steps are required:
+at `mlir/utils/vscode`. As such, contributions should follow the
+[normal LLVM guidelines](https://llvm.org/docs/Contributing.html), with code
+reviews sent to
+[phabricator](https://llvm.org/docs/Contributing.html#how-to-submit-a-patch).
+
+When developing or deploying this extension within the LLVM monorepo, a few
+extra setup steps are required:
 
 *   Copy `mlir/utils/textmate/mlir.json` to the extension directory and rename
     to `grammar.json`.