[Mlir-commits] [mlir] a0ac514 - Revert "Add a static assertions for custom Op<> to not defined data members (NFC)"

Mehdi Amini llvmlistbot at llvm.org
Tue Jun 8 17:46:31 PDT 2021


Author: Mehdi Amini
Date: 2021-06-09T00:46:02Z
New Revision: a0ac51467697d45a353ed9710ca5c75b6bf9b763

URL: https://github.com/llvm/llvm-project/commit/a0ac51467697d45a353ed9710ca5c75b6bf9b763
DIFF: https://github.com/llvm/llvm-project/commit/a0ac51467697d45a353ed9710ca5c75b6bf9b763.diff

LOG: Revert "Add a static assertions for custom Op<> to not defined data members (NFC)"

This reverts commit c0edcec630eb26e12d66dae2f0e1fbf5258cb6ac.

The windows bot was broken by this change.

Added: 
    

Modified: 
    mlir/include/mlir/IR/OpDefinition.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/IR/OpDefinition.h b/mlir/include/mlir/IR/OpDefinition.h
index bb6ff8d4f74e5..dadf028d281f8 100644
--- a/mlir/include/mlir/IR/OpDefinition.h
+++ b/mlir/include/mlir/IR/OpDefinition.h
@@ -1780,8 +1780,6 @@ class Op : public OpState, public Traits<ConcreteType>... {
     return &verifyInvariants;
   }
   static LogicalResult verifyInvariants(Operation *op) {
-    static_assert(sizeof(ConcreteType) == sizeof(OpState),
-                  "Op class aren't allowed to have data members");
     return failure(
         failed(op_definition_impl::verifyTraits<VerifiableTraitsTupleT>(op)) ||
         failed(cast<ConcreteType>(op).verify()));


        


More information about the Mlir-commits mailing list