[Mlir-commits] [mlir] e27c700 - [mlir] Restore markUnknownOpDynamicallyLegal to call isDynamicallyLegal by default

Benjamin Kramer llvmlistbot at llvm.org
Sat Jul 24 06:58:34 PDT 2021


Author: Benjamin Kramer
Date: 2021-07-24T15:54:42+02:00
New Revision: e27c700b9a925b65d19391feee59a50dc39694ea

URL: https://github.com/llvm/llvm-project/commit/e27c700b9a925b65d19391feee59a50dc39694ea
DIFF: https://github.com/llvm/llvm-project/commit/e27c700b9a925b65d19391feee59a50dc39694ea.diff

LOG: [mlir] Restore markUnknownOpDynamicallyLegal to call isDynamicallyLegal by default

Looks like an oversight from b7a464989955e6374b39b518e317b59b510d4dc5

This should probably have a test case ...

Added: 
    

Modified: 
    mlir/include/mlir/Transforms/DialectConversion.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Transforms/DialectConversion.h b/mlir/include/mlir/Transforms/DialectConversion.h
index 32945c2794e5..e490ec14f358 100644
--- a/mlir/include/mlir/Transforms/DialectConversion.h
+++ b/mlir/include/mlir/Transforms/DialectConversion.h
@@ -753,7 +753,8 @@ class ConversionTarget {
     setLegalityCallback(fn);
   }
   void markUnknownOpDynamicallyLegal() {
-    setLegalityCallback([](Operation *) { return true; });
+    setLegalityCallback(
+        [this](Operation *op) { return isDynamicallyLegal(op); });
   }
 
   /// Register the operations of the given dialects as illegal, i.e.


        


More information about the Mlir-commits mailing list