[Mlir-commits] [mlir] 1b535df - [mlir][StandardOps] Fix typos in the td file.

Hanhan Wang llvmlistbot at llvm.org
Fri Jan 22 09:03:37 PST 2021


Author: Hanhan Wang
Date: 2021-01-22T09:03:16-08:00
New Revision: 1b535df1ccd5b1627be7cedc2503642a71ca59ab

URL: https://github.com/llvm/llvm-project/commit/1b535df1ccd5b1627be7cedc2503642a71ca59ab
DIFF: https://github.com/llvm/llvm-project/commit/1b535df1ccd5b1627be7cedc2503642a71ca59ab.diff

LOG: [mlir][StandardOps] Fix typos in the td file.

- Fix arguments name for subview and subtensor.
- Fix a typo in a comment of subtensor's method.

Reviewed By: nicolasvasilache

Differential Revision: https://reviews.llvm.org/D95211

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/StandardOps/IR/Ops.td b/mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
index 5987640a429d..ce1907cb6435 100644
--- a/mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
+++ b/mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
@@ -2795,7 +2795,7 @@ def SubViewOp : BaseOpWithOffsetSizesAndStrides<
 
     The SubView operation supports the following arguments:
 
-    * semref: the "base" memref on which to create a "view" memref.
+    * source: the "base" memref on which to create a "view" memref.
     * offsets: memref-rank number of offsets into the "base" memref at which to
                create the "view" memref.
     * sizes: memref-rank number of sizes which specify the sizes of the result
@@ -2995,7 +2995,7 @@ def SubTensorOp : BaseOpWithOffsetSizesAndStrides<
 
     The subtensor operation supports the following arguments:
 
-    * tensor: the "base" tensor from which to extract a subtensor.
+    * source: the "base" tensor from which to extract a subtensor.
     * offsets: tensor-rank number of offsets into the "base" tensor from which
                to extract the subtensor.
     * sizes: tensor-rank number of sizes which specify the sizes of the result
@@ -3072,9 +3072,9 @@ def SubTensorOp : BaseOpWithOffsetSizesAndStrides<
       return getResult().getType().cast<RankedTensorType>();
     }
 
-    /// A subview result type can be fully inferred from the source type and the
-    /// static representation of offsets, sizes and strides. Special sentinels
-    /// encode the dynamic case.
+    /// A subtensor result type can be fully inferred from the source type and
+    /// the static representation of offsets, sizes and strides. Special
+    /// sentinels encode the dynamic case.
     static Type inferResultType(RankedTensorType sourceRankedTensorType,
                                 ArrayRef<int64_t> staticOffsets,
                                 ArrayRef<int64_t> staticSizes,


        


More information about the Mlir-commits mailing list