[Mlir-commits] [mlir] 4fe7b16 - [mlir] Remove unnecessary llvm.mlir.cast in AsyncToLLVM lowering.

[Christian Sigg]

Author: Christian Sigg
Date: 2021-01-11T14:41:07+01:00
New Revision: 4fe7b16ae3f48a36967e58ab753381cb34295962

URL: https://github.com/llvm/llvm-project/commit/4fe7b16ae3f48a36967e58ab753381cb34295962
DIFF: https://github.com/llvm/llvm-project/commit/4fe7b16ae3f48a36967e58ab753381cb34295962.diff

LOG: [mlir] Remove unnecessary llvm.mlir.cast in AsyncToLLVM lowering.

Reviewed By: ftynse

Differential Revision: https://reviews.llvm.org/D94400

Added: 
    

Modified: 
    mlir/lib/Conversion/AsyncToLLVM/AsyncToLLVM.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Conversion/AsyncToLLVM/AsyncToLLVM.cpp b/mlir/lib/Conversion/AsyncToLLVM/AsyncToLLVM.cpp
index 92b01cea6fca..488432722959 100644
--- a/mlir/lib/Conversion/AsyncToLLVM/AsyncToLLVM.cpp
+++ b/mlir/lib/Conversion/AsyncToLLVM/AsyncToLLVM.cpp
@@ -945,13 +945,7 @@ class AwaitValueOpLowering : public AwaitOpLoweringBase<AwaitOp, ValueType> {
         loc, LLVM::LLVMPointerType::get(llvmValueType), storage.getResult(0));
 
     // Load from the async value storage.
-    auto loaded = rewriter.create<LLVM::LoadOp>(loc, castedStorage.getResult());
-
-    // Cast from LLVM type to the expected value type if necessary. This cast
-    // will become no-op after lowering to LLVM.
-    if (valueType == loaded.getType())
-      return loaded;
-    return rewriter.create<LLVM::DialectCastOp>(loc, valueType, loaded);
+    return rewriter.create<LLVM::LoadOp>(loc, castedStorage.getResult());
   }
 };