[Mlir-commits] [mlir] 7afd5cf - [NFC] Fix -Wrange-loop-analysis warnings.
Mehdi Amini
llvmlistbot at llvm.org
Tue Jan 5 10:44:25 PST 2021
Author: Dan Zheng
Date: 2021-01-05T18:44:17Z
New Revision: 7afd5cfbc757b004cba99d234df4e76b06956b2d
URL: https://github.com/llvm/llvm-project/commit/7afd5cfbc757b004cba99d234df4e76b06956b2d
DIFF: https://github.com/llvm/llvm-project/commit/7afd5cfbc757b004cba99d234df4e76b06956b2d.diff
LOG: [NFC] Fix -Wrange-loop-analysis warnings.
Remove unnecessary `&` from loop variables.
Fix warnings: "loop variable is always a copy because the range does not
return a reference".
```
[240/2862] Building CXX object tools/mlir/tools/mlir-tblgen/CMakeFiles/mlir-tblgen.dir/TypeDefGen.cpp.o
llvm-project/mlir/tools/mlir-tblgen/TypeDefGen.cpp:50:25: warning: loop variable 'typeDef' is always a copy because the range of type 'llvm::iterator_range<llvm::mapped_iterator<std::__1::__wrap_iter<llvm::Record **>, (lambda at llvm-project/mlir/tools/mlir-tblgen/TypeDefGen.cpp:40:16), mlir::tblgen::TypeDef> >' does not return a reference [-Wrange-loop-analysis]
for (const TypeDef &typeDef : defs)
^
llvm-project/mlir/tools/mlir-tblgen/TypeDefGen.cpp:50:10: note: use non-reference type 'mlir::tblgen::TypeDef'
for (const TypeDef &typeDef : defs)
^~~~~~~~~~~~~~~~~~~~~~~~
llvm-project/mlir/tools/mlir-tblgen/TypeDefGen.cpp:64:23: warning: loop variable 'typeDef' is always a copy because the range of type 'llvm::iterator_range<llvm::mapped_iterator<std::__1::__wrap_iter<llvm::Record **>, (lambda at llvm-project/mlir/tools/mlir-tblgen/TypeDefGen.cpp:40:16), mlir::tblgen::TypeDef> >' does not return a reference [-Wrange-loop-analysis]
for (const TypeDef &typeDef : defs)
^
llvm-project/mlir/tools/mlir-tblgen/TypeDefGen.cpp:64:8: note: use non-reference type 'mlir::tblgen::TypeDef'
for (const TypeDef &typeDef : defs)
^~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
[1934/2862] Building CXX object tools...Files/toyc-ch4.dir/mlir/MLIRGen.cpp.o
llvm-project/mlir/examples/toy/Ch4/mlir/MLIRGen.cpp:139:22: warning: loop variable 'name_value' is always a copy because the range of type 'detail::zippy<detail::zip_shortest, ArrayRef<unique_ptr<VariableExprAST, default_delete<VariableExprAST> > > &, MutableArrayRef<BlockArgument> >' does not return a reference [-Wrange-loop-analysis]
for (const auto &name_value :
^
llvm-project/mlir/examples/toy/Ch4/mlir/MLIRGen.cpp:139:10: note: use non-reference type 'std::__1::tuple<const std::__1::unique_ptr<toy::VariableExprAST, std::__1::default_delete<toy::VariableExprAST> > &, mlir::BlockArgument &>'
for (const auto &name_value :
^~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
[1940/2862] Building CXX object tools...Files/toyc-ch5.dir/mlir/MLIRGen.cpp.o
llvm-project/mlir/examples/toy/Ch5/mlir/MLIRGen.cpp:139:22: warning: loop variable 'name_value' is always a copy because the range of type 'detail::zippy<detail::zip_shortest, ArrayRef<unique_ptr<VariableExprAST, default_delete<VariableExprAST> > > &, MutableArrayRef<BlockArgument> >' does not return a reference [-Wrange-loop-analysis]
for (const auto &name_value :
^
llvm-project/mlir/examples/toy/Ch5/mlir/MLIRGen.cpp:139:10: note: use non-reference type 'std::__1::tuple<const std::__1::unique_ptr<toy::VariableExprAST, std::__1::default_delete<toy::VariableExprAST> > &, mlir::BlockArgument &>'
for (const auto &name_value :
^~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
Reviewed By: jpienaar
Differential Revision: https://reviews.llvm.org/D94003
Added:
Modified:
mlir/examples/toy/Ch2/mlir/MLIRGen.cpp
mlir/examples/toy/Ch3/mlir/MLIRGen.cpp
mlir/examples/toy/Ch4/mlir/MLIRGen.cpp
mlir/examples/toy/Ch5/mlir/MLIRGen.cpp
mlir/examples/toy/Ch6/mlir/MLIRGen.cpp
mlir/examples/toy/Ch7/mlir/Dialect.cpp
mlir/examples/toy/Ch7/mlir/MLIRGen.cpp
mlir/tools/mlir-tblgen/TypeDefGen.cpp
Removed:
################################################################################
diff --git a/mlir/examples/toy/Ch2/mlir/MLIRGen.cpp b/mlir/examples/toy/Ch2/mlir/MLIRGen.cpp
index 282a1bc76815..8b9f9dbdf190 100644
--- a/mlir/examples/toy/Ch2/mlir/MLIRGen.cpp
+++ b/mlir/examples/toy/Ch2/mlir/MLIRGen.cpp
@@ -136,10 +136,10 @@ class MLIRGenImpl {
auto protoArgs = funcAST.getProto()->getArgs();
// Declare all the function arguments in the symbol table.
- for (const auto &name_value :
+ for (const auto nameValue :
llvm::zip(protoArgs, entryBlock.getArguments())) {
- if (failed(declare(std::get<0>(name_value)->getName(),
- std::get<1>(name_value))))
+ if (failed(declare(std::get<0>(nameValue)->getName(),
+ std::get<1>(nameValue))))
return nullptr;
}
diff --git a/mlir/examples/toy/Ch3/mlir/MLIRGen.cpp b/mlir/examples/toy/Ch3/mlir/MLIRGen.cpp
index 282a1bc76815..8b9f9dbdf190 100644
--- a/mlir/examples/toy/Ch3/mlir/MLIRGen.cpp
+++ b/mlir/examples/toy/Ch3/mlir/MLIRGen.cpp
@@ -136,10 +136,10 @@ class MLIRGenImpl {
auto protoArgs = funcAST.getProto()->getArgs();
// Declare all the function arguments in the symbol table.
- for (const auto &name_value :
+ for (const auto nameValue :
llvm::zip(protoArgs, entryBlock.getArguments())) {
- if (failed(declare(std::get<0>(name_value)->getName(),
- std::get<1>(name_value))))
+ if (failed(declare(std::get<0>(nameValue)->getName(),
+ std::get<1>(nameValue))))
return nullptr;
}
diff --git a/mlir/examples/toy/Ch4/mlir/MLIRGen.cpp b/mlir/examples/toy/Ch4/mlir/MLIRGen.cpp
index c92010594ed5..b5e6c707d894 100644
--- a/mlir/examples/toy/Ch4/mlir/MLIRGen.cpp
+++ b/mlir/examples/toy/Ch4/mlir/MLIRGen.cpp
@@ -136,10 +136,10 @@ class MLIRGenImpl {
auto protoArgs = funcAST.getProto()->getArgs();
// Declare all the function arguments in the symbol table.
- for (const auto &name_value :
+ for (const auto nameValue :
llvm::zip(protoArgs, entryBlock.getArguments())) {
- if (failed(declare(std::get<0>(name_value)->getName(),
- std::get<1>(name_value))))
+ if (failed(declare(std::get<0>(nameValue)->getName(),
+ std::get<1>(nameValue))))
return nullptr;
}
diff --git a/mlir/examples/toy/Ch5/mlir/MLIRGen.cpp b/mlir/examples/toy/Ch5/mlir/MLIRGen.cpp
index c92010594ed5..b5e6c707d894 100644
--- a/mlir/examples/toy/Ch5/mlir/MLIRGen.cpp
+++ b/mlir/examples/toy/Ch5/mlir/MLIRGen.cpp
@@ -136,10 +136,10 @@ class MLIRGenImpl {
auto protoArgs = funcAST.getProto()->getArgs();
// Declare all the function arguments in the symbol table.
- for (const auto &name_value :
+ for (const auto nameValue :
llvm::zip(protoArgs, entryBlock.getArguments())) {
- if (failed(declare(std::get<0>(name_value)->getName(),
- std::get<1>(name_value))))
+ if (failed(declare(std::get<0>(nameValue)->getName(),
+ std::get<1>(nameValue))))
return nullptr;
}
diff --git a/mlir/examples/toy/Ch6/mlir/MLIRGen.cpp b/mlir/examples/toy/Ch6/mlir/MLIRGen.cpp
index c92010594ed5..b5e6c707d894 100644
--- a/mlir/examples/toy/Ch6/mlir/MLIRGen.cpp
+++ b/mlir/examples/toy/Ch6/mlir/MLIRGen.cpp
@@ -136,10 +136,10 @@ class MLIRGenImpl {
auto protoArgs = funcAST.getProto()->getArgs();
// Declare all the function arguments in the symbol table.
- for (const auto &name_value :
+ for (const auto nameValue :
llvm::zip(protoArgs, entryBlock.getArguments())) {
- if (failed(declare(std::get<0>(name_value)->getName(),
- std::get<1>(name_value))))
+ if (failed(declare(std::get<0>(nameValue)->getName(),
+ std::get<1>(nameValue))))
return nullptr;
}
diff --git a/mlir/examples/toy/Ch7/mlir/Dialect.cpp b/mlir/examples/toy/Ch7/mlir/Dialect.cpp
index 5c87e5a886fb..659b82e6d80e 100644
--- a/mlir/examples/toy/Ch7/mlir/Dialect.cpp
+++ b/mlir/examples/toy/Ch7/mlir/Dialect.cpp
@@ -244,7 +244,7 @@ static mlir::LogicalResult verifyConstantForType(mlir::Type type,
// Check that each of the elements are valid.
llvm::ArrayRef<mlir::Attribute> attrElementValues = attrValue.getValue();
- for (const auto &it : llvm::zip(resultElementTypes, attrElementValues))
+ for (const auto it : llvm::zip(resultElementTypes, attrElementValues))
if (failed(verifyConstantForType(std::get<0>(it), std::get<1>(it), op)))
return mlir::failure();
return mlir::success();
diff --git a/mlir/examples/toy/Ch7/mlir/MLIRGen.cpp b/mlir/examples/toy/Ch7/mlir/MLIRGen.cpp
index 401e4eb961cc..e69e9a22febc 100644
--- a/mlir/examples/toy/Ch7/mlir/MLIRGen.cpp
+++ b/mlir/examples/toy/Ch7/mlir/MLIRGen.cpp
@@ -190,9 +190,9 @@ class MLIRGenImpl {
auto protoArgs = funcAST.getProto()->getArgs();
// Declare all the function arguments in the symbol table.
- for (const auto &name_value :
+ for (const auto nameValue :
llvm::zip(protoArgs, entryBlock.getArguments())) {
- if (failed(declare(*std::get<0>(name_value), std::get<1>(name_value))))
+ if (failed(declare(*std::get<0>(nameValue), std::get<1>(nameValue))))
return nullptr;
}
diff --git a/mlir/tools/mlir-tblgen/TypeDefGen.cpp b/mlir/tools/mlir-tblgen/TypeDefGen.cpp
index 64239441581d..afe174ff84bf 100644
--- a/mlir/tools/mlir-tblgen/TypeDefGen.cpp
+++ b/mlir/tools/mlir-tblgen/TypeDefGen.cpp
@@ -47,7 +47,7 @@ static void findAllTypeDefs(const llvm::RecordKeeper &recordKeeper,
return;
llvm::SmallSet<Dialect, 4> dialects;
- for (const TypeDef &typeDef : defs)
+ for (const TypeDef typeDef : defs)
dialects.insert(typeDef.getDialect());
if (dialects.size() != 1)
llvm::PrintFatalError("TypeDefs belonging to more than one dialect. Must "
@@ -61,7 +61,7 @@ static void findAllTypeDefs(const llvm::RecordKeeper &recordKeeper,
"generate types via '--typedefs-dialect'.");
}
- for (const TypeDef &typeDef : defs)
+ for (const TypeDef typeDef : defs)
if (typeDef.getDialect().getName().equals(dialectName))
typeDefs.push_back(typeDef);
}
More information about the Mlir-commits
mailing list