[Mlir-commits] [mlir] bb6109a - Pass the LLVMTypeConverter by reference in MemRefBuilder (NFC)

[Mehdi Amini]

Author: Mehdi Amini
Date: 2022-01-01T01:56:50Z
New Revision: bb6109aae6b47ce56388c9c426c959c87b6a44d5

URL: https://github.com/llvm/llvm-project/commit/bb6109aae6b47ce56388c9c426c959c87b6a44d5
DIFF: https://github.com/llvm/llvm-project/commit/bb6109aae6b47ce56388c9c426c959c87b6a44d5.diff

LOG: Pass the LLVMTypeConverter by reference in MemRefBuilder (NFC)

This is a fairly large structure (952B according to Coverity), it was
already passed by reference in most places but not consistently.

Added: 
    

Modified: 
    mlir/include/mlir/Conversion/LLVMCommon/MemRefBuilder.h
    mlir/lib/Conversion/LLVMCommon/MemRefBuilder.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Conversion/LLVMCommon/MemRefBuilder.h b/mlir/include/mlir/Conversion/LLVMCommon/MemRefBuilder.h
index f9eede519ca01..8f755d5a1cb3d 100644
--- a/mlir/include/mlir/Conversion/LLVMCommon/MemRefBuilder.h
+++ b/mlir/include/mlir/Conversion/LLVMCommon/MemRefBuilder.h
@@ -223,7 +223,7 @@ class UnrankedMemRefDescriptor : public StructBuilder {
                     Value index);
   /// Builds IR inserting the size[index] into the descriptor.
   static void setSize(OpBuilder &builder, Location loc,
-                      LLVMTypeConverter typeConverter, Value sizeBasePtr,
+                      LLVMTypeConverter &typeConverter, Value sizeBasePtr,
                       Value index, Value size);
 
   /// Builds IR extracting the pointer to the first element of the stride array.
@@ -232,11 +232,11 @@ class UnrankedMemRefDescriptor : public StructBuilder {
                              Value sizeBasePtr, Value rank);
   /// Builds IR extracting the stride[index] from the descriptor.
   static Value stride(OpBuilder &builder, Location loc,
-                      LLVMTypeConverter typeConverter, Value strideBasePtr,
+                      LLVMTypeConverter &typeConverter, Value strideBasePtr,
                       Value index, Value stride);
   /// Builds IR inserting the stride[index] into the descriptor.
   static void setStride(OpBuilder &builder, Location loc,
-                        LLVMTypeConverter typeConverter, Value strideBasePtr,
+                        LLVMTypeConverter &typeConverter, Value strideBasePtr,
                         Value index, Value stride);
 };
 

diff  --git a/mlir/lib/Conversion/LLVMCommon/MemRefBuilder.cpp b/mlir/lib/Conversion/LLVMCommon/MemRefBuilder.cpp
index 10ce877e24fa4..edb43b3cce373 100644
--- a/mlir/lib/Conversion/LLVMCommon/MemRefBuilder.cpp
+++ b/mlir/lib/Conversion/LLVMCommon/MemRefBuilder.cpp
@@ -487,7 +487,7 @@ Value UnrankedMemRefDescriptor::size(OpBuilder &builder, Location loc,
 }
 
 void UnrankedMemRefDescriptor::setSize(OpBuilder &builder, Location loc,
-                                       LLVMTypeConverter typeConverter,
+                                       LLVMTypeConverter &typeConverter,
                                        Value sizeBasePtr, Value index,
                                        Value size) {
   Type indexPtrTy = LLVM::LLVMPointerType::get(typeConverter.getIndexType());
@@ -505,7 +505,7 @@ Value UnrankedMemRefDescriptor::strideBasePtr(OpBuilder &builder, Location loc,
 }
 
 Value UnrankedMemRefDescriptor::stride(OpBuilder &builder, Location loc,
-                                       LLVMTypeConverter typeConverter,
+                                       LLVMTypeConverter &typeConverter,
                                        Value strideBasePtr, Value index,
                                        Value stride) {
   Type indexPtrTy = LLVM::LLVMPointerType::get(typeConverter.getIndexType());
@@ -515,7 +515,7 @@ Value UnrankedMemRefDescriptor::stride(OpBuilder &builder, Location loc,
 }
 
 void UnrankedMemRefDescriptor::setStride(OpBuilder &builder, Location loc,
-                                         LLVMTypeConverter typeConverter,
+                                         LLVMTypeConverter &typeConverter,
                                          Value strideBasePtr, Value index,
                                          Value stride) {
   Type indexPtrTy = LLVM::LLVMPointerType::get(typeConverter.getIndexType());