[Mlir-commits] [mlir] 8637be7 - Remove redundant return after return in CodegenStrategy (NFC)

Mehdi Amini llvmlistbot at llvm.org
Fri Dec 31 17:14:55 PST 2021


Author: Mehdi Amini
Date: 2022-01-01T01:14:27Z
New Revision: 8637be74a038ece5f97040895963e0ef6797f324

URL: https://github.com/llvm/llvm-project/commit/8637be74a038ece5f97040895963e0ef6797f324
DIFF: https://github.com/llvm/llvm-project/commit/8637be74a038ece5f97040895963e0ef6797f324.diff

LOG: Remove redundant return after return in CodegenStrategy (NFC)

Reported by Coverity

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/Linalg/Transforms/CodegenStrategy.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/Linalg/Transforms/CodegenStrategy.h b/mlir/include/mlir/Dialect/Linalg/Transforms/CodegenStrategy.h
index 9a32279f84216..a532478d72afd 100644
--- a/mlir/include/mlir/Dialect/Linalg/Transforms/CodegenStrategy.h
+++ b/mlir/include/mlir/Dialect/Linalg/Transforms/CodegenStrategy.h
@@ -242,7 +242,6 @@ struct CodegenStrategy {
   promoteIf(bool b, StringRef opName, linalg::LinalgPromotionOptions options,
             LinalgTransformationFilter::FilterFunction f = nullptr) {
     return b ? promote(opName, options, f) : *this;
-    return *this;
   }
   /// Append a pattern to generalize named operations.
   CodegenStrategy &
@@ -257,7 +256,6 @@ struct CodegenStrategy {
   generalizeIf(bool b, StringRef opName,
                LinalgTransformationFilter::FilterFunction f = nullptr) {
     return b ? generalize(opName, f) : *this;
-    return *this;
   }
   /// Append a pattern to interchange iterators.
   CodegenStrategy &
@@ -272,7 +270,6 @@ struct CodegenStrategy {
   interchangeIf(bool b, ArrayRef<int64_t> iteratorInterchange,
                 LinalgTransformationFilter::FilterFunction f = nullptr) {
     return b ? interchange(iteratorInterchange, f) : *this;
-    return *this;
   }
   /// Append patterns to decompose convolutions.
   CodegenStrategy &
@@ -284,7 +281,6 @@ struct CodegenStrategy {
   CodegenStrategy &
   decomposeIf(bool b, LinalgTransformationFilter::FilterFunction f = nullptr) {
     return b ? decompose(f) : *this;
-    return *this;
   }
   /// Append a pattern to rewrite `LinalgOpType` as a vector operation.
   CodegenStrategy &
@@ -302,7 +298,6 @@ struct CodegenStrategy {
               LinalgTransformationFilter::FilterFunction f = nullptr,
               bool vectorizePadding = false) {
     return b ? vectorize(opName, f, vectorizePadding) : *this;
-    return *this;
   }
   /// Append a pattern to lower all vector operations.
   CodegenStrategy &vectorLowering(LinalgVectorLoweringOptions options) {


        


More information about the Mlir-commits mailing list