[Mlir-commits] [mlir] 0ca00c3 - [mlir][vector] Remove default value in populateVectorMultiReductionLoweringPatterns

[Diego Caballero]

Author: Diego Caballero
Date: 2021-12-16T09:45:34Z
New Revision: 0ca00c353823627c814fdff70631d15549a7b559

URL: https://github.com/llvm/llvm-project/commit/0ca00c353823627c814fdff70631d15549a7b559
DIFF: https://github.com/llvm/llvm-project/commit/0ca00c353823627c814fdff70631d15549a7b559.diff

LOG: [mlir][vector] Remove default value in populateVectorMultiReductionLoweringPatterns

Having a default value for the lowering strategy of the multi-reduction op has proven
to be unexpected by users. This patch is dropping the default value so that users have
to explicitly choose the lowering strategy to be applied.

Reviewed By: nicolasvasilache

Differential Revision: https://reviews.llvm.org/D115805

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/Vector/VectorRewritePatterns.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/Vector/VectorRewritePatterns.h b/mlir/include/mlir/Dialect/Vector/VectorRewritePatterns.h
index 433ab8df0571e..22c1b4d965019 100644
--- a/mlir/include/mlir/Dialect/Vector/VectorRewritePatterns.h
+++ b/mlir/include/mlir/Dialect/Vector/VectorRewritePatterns.h
@@ -157,9 +157,7 @@ void populateVectorTransposeLoweringPatterns(
 /// the other patterns can kick in, thus fully exiting out of the
 /// vector.multi_reduction abstraction.
 void populateVectorMultiReductionLoweringPatterns(
-    RewritePatternSet &patterns,
-    VectorMultiReductionLowering options =
-        VectorMultiReductionLowering::InnerParallel);
+    RewritePatternSet &patterns, VectorMultiReductionLowering options);
 
 /// Collects patterns to progressively lower vector contraction ops on high-D
 /// into low-D reduction and product ops.