[Mlir-commits] [mlir] 04d083b - [mlir][NFC] Use const reference for loop variables.

Adrian Kuegel llvmlistbot at llvm.org
Fri Dec 3 04:08:34 PST 2021


Author: Adrian Kuegel
Date: 2021-12-03T13:07:54+01:00
New Revision: 04d083b19e6eb80587cc27fa3996121c8c4bddbc

URL: https://github.com/llvm/llvm-project/commit/04d083b19e6eb80587cc27fa3996121c8c4bddbc
DIFF: https://github.com/llvm/llvm-project/commit/04d083b19e6eb80587cc27fa3996121c8c4bddbc.diff

LOG: [mlir][NFC] Use const reference for loop variables.

Added: 
    

Modified: 
    mlir/lib/Dialect/Linalg/ComprehensiveBufferize/BufferizableOpInterface.cpp
    mlir/lib/Dialect/Linalg/ComprehensiveBufferize/ModuleBufferization.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/Linalg/ComprehensiveBufferize/BufferizableOpInterface.cpp b/mlir/lib/Dialect/Linalg/ComprehensiveBufferize/BufferizableOpInterface.cpp
index 61c4f8ee4a05..6a75398cd5e9 100644
--- a/mlir/lib/Dialect/Linalg/ComprehensiveBufferize/BufferizableOpInterface.cpp
+++ b/mlir/lib/Dialect/Linalg/ComprehensiveBufferize/BufferizableOpInterface.cpp
@@ -556,14 +556,14 @@ static MemRefType getAllocationTypeAndShape(OpBuilder &b, Location loc,
       reifiedShapes = true;
       OpResult resultValue = shapedValue.dyn_cast<OpResult>();
       auto &shape = resultDims[resultValue.getResultNumber()];
-      for (auto dim : enumerate(allocMemRefType.getShape()))
+      for (const auto &dim : enumerate(allocMemRefType.getShape()))
         if (ShapedType::isDynamic(dim.value()))
           dynShape.push_back(shape[dim.index()]);
     }
   }
 
   if (!reifiedShapes) {
-    for (auto dim : enumerate(allocMemRefType.getShape()))
+    for (const auto &dim : enumerate(allocMemRefType.getShape()))
       if (ShapedType::isDynamic(dim.value())) {
         assert((shapedValue.getType().isa<UnrankedMemRefType>() ||
                 shapedValue.getType().isa<MemRefType>()) &&

diff  --git a/mlir/lib/Dialect/Linalg/ComprehensiveBufferize/ModuleBufferization.cpp b/mlir/lib/Dialect/Linalg/ComprehensiveBufferize/ModuleBufferization.cpp
index 9ed8055af2b8..d24e7e8b121c 100644
--- a/mlir/lib/Dialect/Linalg/ComprehensiveBufferize/ModuleBufferization.cpp
+++ b/mlir/lib/Dialect/Linalg/ComprehensiveBufferize/ModuleBufferization.cpp
@@ -370,7 +370,7 @@ static void layoutPostProcessing(ModuleOp moduleOp) {
     SmallVector<Type> argumentTypes;
     // Iterate on each function argument and check it it was marked with a
     // desired layout.
-    for (auto it : llvm::enumerate(funcOp.getType().getInputs())) {
+    for (const auto &it : llvm::enumerate(funcOp.getType().getInputs())) {
       int argNumber = it.index();
       Type inputType = it.value();
       auto memrefType = inputType.dyn_cast<MemRefType>();


        


More information about the Mlir-commits mailing list