[Mlir-commits] [mlir] 985789c - Update mergeLocalIds docs

[llvmlistbot at llvm.org]

Author: Groverkss
Date: 2021-12-03T03:23:17+05:30
New Revision: 985789ce0b91cac5dbebd56ed068043be13fe8da

URL: https://github.com/llvm/llvm-project/commit/985789ce0b91cac5dbebd56ed068043be13fe8da
DIFF: https://github.com/llvm/llvm-project/commit/985789ce0b91cac5dbebd56ed068043be13fe8da.diff

LOG: Update mergeLocalIds docs

Added: 
    

Modified: 
    mlir/include/mlir/Analysis/AffineStructures.h
    mlir/lib/Analysis/AffineStructures.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Analysis/AffineStructures.h b/mlir/include/mlir/Analysis/AffineStructures.h
index 4a52971186c6..9e7c7b504ed0 100644
--- a/mlir/include/mlir/Analysis/AffineStructures.h
+++ b/mlir/include/mlir/Analysis/AffineStructures.h
@@ -441,11 +441,9 @@ class FlatAffineConstraints {
   /// variables.
   void convertDimToLocal(unsigned dimStart, unsigned dimLimit);
 
-  /// Merge and align local ids of `this` and `other`. Any local identifiers
-  /// which can be represented as divisions in terms of dimension and symbol
-  /// ids with constant denominator are extracted and local ids with same
-  /// division representation are merged. Number of dimension and symbol ids
-  /// should match in `this` and `other`.
+  /// Merges and aligns local ids of `this` and `other`. Local ids with
+  /// identical division representations are merged. The number of dimensions
+  /// and symbol ids should match in `this` and `other`.
   void mergeLocalIds(FlatAffineConstraints &other);
 
   /// Removes all equalities and inequalities.
@@ -531,7 +529,7 @@ class FlatAffineConstraints {
   /// Normalized each constraints by the GCD of its coefficients.
   void normalizeConstraintsByGCD();
 
-  /// Get division representation for each local identifier. If no local
+  /// Get division representations for each local identifier. If no local
   /// representation exists for the `i^th` local identifier, denominator[i] is
   /// set to 0.
   void getLocalIdsReprs(std::vector<SmallVector<int64_t, 8>> &reprs,

diff  --git a/mlir/lib/Analysis/AffineStructures.cpp b/mlir/lib/Analysis/AffineStructures.cpp
index c361f11e2b98..24ad0f1cb826 100644
--- a/mlir/lib/Analysis/AffineStructures.cpp
+++ b/mlir/lib/Analysis/AffineStructures.cpp
@@ -1960,11 +1960,6 @@ static void mergeDivision(FlatAffineConstraints &fac, unsigned pos1,
   fac.removeId(pos2);
 }
 
-/// Merge and align local ids of `this` and `other`. Any local identifiers
-/// which can be represented as divisions in terms of dimension and symbol
-/// ids with constant denominator are extracted and local ids with same
-/// division representation are merged. Number of dimension and symbol ids
-/// should match in `this` and `other`.
 void FlatAffineConstraints::mergeLocalIds(FlatAffineConstraints &other) {
   assert(getNumDimIds() == other.getNumDimIds() &&
          "Number of dimension ids should match");