[Mlir-commits] [mlir] 9a66d33 - [mlir] Fix the postsubmit comments in https://reviews.llvm.org/D101445

Alexander Belyaev llvmlistbot at llvm.org
Wed Apr 28 05:58:21 PDT 2021


Author: Alexander Belyaev
Date: 2021-04-28T14:58:02+02:00
New Revision: 9a66d334522d6b69d7d1ea0dbc1b04ae0d43b959

URL: https://github.com/llvm/llvm-project/commit/9a66d334522d6b69d7d1ea0dbc1b04ae0d43b959
DIFF: https://github.com/llvm/llvm-project/commit/9a66d334522d6b69d7d1ea0dbc1b04ae0d43b959.diff

LOG: [mlir] Fix the postsubmit comments in https://reviews.llvm.org/D101445

Added: 
    

Modified: 
    mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp b/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
index 8a80036688cd..17ecab19c2a8 100644
--- a/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
+++ b/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
@@ -174,9 +174,9 @@ static LogicalResult foldMemRefCastInTiledLoopOp(TiledLoopOp op) {
     auto castOp = operand.get().getDefiningOp<memref::CastOp>();
     if (castOp && memref::CastOp::canFoldIntoConsumerOp(castOp)) {
       operand.set(castOp.getOperand());
-      auto newBbArg =
+      BlockArgument newBbArg =
           body->insertArgument(bbArgIndex, castOp.getOperand().getType());
-      auto oldBbArg = body->getArgument(newBbArg.getArgNumber() + 1);
+      BlockArgument oldBbArg = body->getArgument(newBbArg.getArgNumber() + 1);
 
       // Insert memref.cast back to the original type.
       oldBbArg.replaceAllUsesWith(
@@ -2120,7 +2120,6 @@ struct TiledLoopInputsFolder : public OpRewritePattern<linalg::TiledLoopOp> {
       if (!in.getType().isa<RankedTensorType>() || !bbArg.use_empty()) {
         oldInputIdToNew[index] = newInputs.size();
         newInputs.push_back(in);
-        continue;
       }
     }
     if (newInputs.size() == tiledLoop.inputs().size())


        


More information about the Mlir-commits mailing list