[Mlir-commits] [mlir] c23cb8b - Fix "incorrect" assertions in Linalg/EDSC/Builders.cpp (NFC)

[Mehdi Amini]

Author: Mehdi Amini
Date: 2020-10-30T05:16:59Z
New Revision: c23cb8b032eb926f1d9c96c1415d6efd305eb59a

URL: https://github.com/llvm/llvm-project/commit/c23cb8b032eb926f1d9c96c1415d6efd305eb59a
DIFF: https://github.com/llvm/llvm-project/commit/c23cb8b032eb926f1d9c96c1415d6efd305eb59a.diff

LOG: Fix "incorrect" assertions in Linalg/EDSC/Builders.cpp (NFC)

It is semantically equivalent, but the intent was really lost there.
This fixes a warning/error from MSVC as well, see PR48013

Added: 
    

Modified: 
    mlir/lib/Dialect/Linalg/EDSC/Builders.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/Linalg/EDSC/Builders.cpp b/mlir/lib/Dialect/Linalg/EDSC/Builders.cpp
index 20522fe8499f..366aa0fdcc5a 100644
--- a/mlir/lib/Dialect/Linalg/EDSC/Builders.cpp
+++ b/mlir/lib/Dialect/Linalg/EDSC/Builders.cpp
@@ -114,7 +114,7 @@ Operation *mlir::edsc::ops::linalg_generic_pointwise(
   SmallVector<IteratorType, 4> iterTypes(O.getExprs().size(),
                                          IteratorType::Parallel);
   auto fun = [&unaryOp](ValueRange args) {
-    assert(!args.empty() >= 1 && "expected >= 1 block arguments");
+    assert(!args.empty() && "expected >= 1 block arguments");
     Value a(args[0]);
     linalg_yield(unaryOp(a));
   };