[Mlir-commits] [mlir] 0c15a1b - [mlir] Fix sporadic build failures due to missing dependency

[Stella Stamenova]

Author: Stella Stamenova
Date: 2020-10-13T09:53:07-07:00
New Revision: 0c15a1b4bcefc1eb434e07aa31b7a08109ccd27e

URL: https://github.com/llvm/llvm-project/commit/0c15a1b4bcefc1eb434e07aa31b7a08109ccd27e
DIFF: https://github.com/llvm/llvm-project/commit/0c15a1b4bcefc1eb434e07aa31b7a08109ccd27e.diff

LOG: [mlir] Fix sporadic build failures due to missing dependency

The build of MLIR occasionally fails (especially on Windows) because there is missing dependency between MLIRLLVMIR and MLIROpenMPOpsIncGen.

1) LLVMDialect.cpp includes LLVMDialect.h
2) LLVMDialect.h includes OpenMPDialect.h
3) OpenMPDialect.h includes OpenMPOpsDialect.h.inc, OpenMPOpsEnums.h.inc and OpenMPOps.h.inc

The OpenMP .inc files are generated by MLIROpenMPOpsIncGen, so MLIRLLVMIR which builds LLVMDialect.cpp should depend on MLIROpenMPOpsIncGen

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D89275

Added: 
    

Modified: 
    mlir/lib/Dialect/LLVMIR/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/LLVMIR/CMakeLists.txt b/mlir/lib/Dialect/LLVMIR/CMakeLists.txt
index 9827b86e8b24..db1a5c4c80aa 100644
--- a/mlir/lib/Dialect/LLVMIR/CMakeLists.txt
+++ b/mlir/lib/Dialect/LLVMIR/CMakeLists.txt
@@ -11,6 +11,7 @@ add_mlir_dialect_library(MLIRLLVMIR
   DEPENDS
   MLIRLLVMOpsIncGen
   MLIRLLVMConversionsIncGen
+  MLIROpenMPOpsIncGen
   intrinsics_gen
 
   LINK_COMPONENTS