[Mlir-commits] [mlir] e207927 - NFC: Address post-commit doc/formatting comments on TypeID.h.
Stella Laurenzo
llvmlistbot at llvm.org
Fri Oct 9 12:17:30 PDT 2020
Author: Stella Laurenzo
Date: 2020-10-09T12:16:45-07:00
New Revision: e20792795065b2fb41128537314044f0a8f0a912
URL: https://github.com/llvm/llvm-project/commit/e20792795065b2fb41128537314044f0a8f0a912
DIFF: https://github.com/llvm/llvm-project/commit/e20792795065b2fb41128537314044f0a8f0a912.diff
LOG: NFC: Address post-commit doc/formatting comments on TypeID.h.
Added:
Modified:
mlir/include/mlir/Support/TypeID.h
Removed:
################################################################################
diff --git a/mlir/include/mlir/Support/TypeID.h b/mlir/include/mlir/Support/TypeID.h
index ef19182882c6..fb8a2215b669 100644
--- a/mlir/include/mlir/Support/TypeID.h
+++ b/mlir/include/mlir/Support/TypeID.h
@@ -88,6 +88,7 @@ class TypeID {
/// The storage of this type info object.
const Storage *storage;
+ // See TypeIDExported below for an explanation of the trampoline behavior.
friend struct detail::TypeIDExported;
};
@@ -97,6 +98,7 @@ inline ::llvm::hash_code hash_value(TypeID id) {
}
namespace detail {
+
/// The static local instance of each get method must be emitted with
/// "default" (public) visibility across all shared libraries, regardless of
/// whether they are compiled with hidden visibility or not. The only reliable
@@ -122,6 +124,7 @@ struct LLVM_EXTERNAL_VISIBILITY TypeIDExported {
return TypeID(&instance);
}
};
+
} // namespace detail
template <typename T>
More information about the Mlir-commits
mailing list