[Mlir-commits] [mlir] 21b346b - [mlir] use STATUS instead of CHECK_* in MLIRDetectPythonEnv.cmake

Alex Zinenko llvmlistbot at llvm.org
Tue Nov 24 15:09:43 PST 2020


Author: Alex Zinenko
Date: 2020-11-25T00:09:33+01:00
New Revision: 21b346bd70baa8e69d60988cc41cfd7b6ec98dfc

URL: https://github.com/llvm/llvm-project/commit/21b346bd70baa8e69d60988cc41cfd7b6ec98dfc
DIFF: https://github.com/llvm/llvm-project/commit/21b346bd70baa8e69d60988cc41cfd7b6ec98dfc.diff

LOG: [mlir] use STATUS instead of CHECK_* in MLIRDetectPythonEnv.cmake

CHECK_* directives for message() where added in Cmake 3.17, LLVM
requires 3.14 as minimum so they may not be intepreted correctly and
just print "CHECK_*" into the message stream. Replace them with STATUS.

Reviewed By: stellaraccident

Differential Revision: https://reviews.llvm.org/D91959

Added: 
    

Modified: 
    mlir/cmake/modules/MLIRDetectPythonEnv.cmake

Removed: 
    


################################################################################
diff  --git a/mlir/cmake/modules/MLIRDetectPythonEnv.cmake b/mlir/cmake/modules/MLIRDetectPythonEnv.cmake
index 2a3d1fa1a3c3..77bb700c919a 100644
--- a/mlir/cmake/modules/MLIRDetectPythonEnv.cmake
+++ b/mlir/cmake/modules/MLIRDetectPythonEnv.cmake
@@ -8,7 +8,7 @@ function(mlir_detect_pybind11_install)
   if(pybind11_DIR)
     message(STATUS "Using explicit pybind11 cmake directory: ${pybind11_DIR} (-Dpybind11_DIR to change)")
   else()
-    message(CHECK_START "Checking for pybind11 in python path...")
+    message(STATUS "Checking for pybind11 in python path...")
     execute_process(
       COMMAND "${Python3_EXECUTABLE}"
       -c "import pybind11;print(pybind11.get_cmake_dir(), end='')"
@@ -17,10 +17,10 @@ function(mlir_detect_pybind11_install)
       OUTPUT_VARIABLE PACKAGE_DIR
       ERROR_QUIET)
     if(NOT STATUS EQUAL "0")
-      message(CHECK_FAIL "not found (install via 'pip install pybind11' or set pybind11_DIR)")
+      message(STATUS "not found (install via 'pip install pybind11' or set pybind11_DIR)")
       return()
     endif()
-    message(CHECK_PASS "found (${PACKAGE_DIR})")
+    message(STATUS "found (${PACKAGE_DIR})")
     set(pybind11_DIR "${PACKAGE_DIR}" PARENT_SCOPE)
   endif()
 endfunction()


        


More information about the Mlir-commits mailing list