[Mlir-commits] [mlir] 15481bb - [mlir][Python] Fix the last remaining instance of PYTHON_EXECUTABLE.

Stella Laurenzo llvmlistbot at llvm.org
Tue Nov 24 09:56:20 PST 2020


Author: Stella Laurenzo
Date: 2020-11-24T17:56:05Z
New Revision: 15481bba1ff2c03ff969cba8e0e7c37888f966a3

URL: https://github.com/llvm/llvm-project/commit/15481bba1ff2c03ff969cba8e0e7c37888f966a3
DIFF: https://github.com/llvm/llvm-project/commit/15481bba1ff2c03ff969cba8e0e7c37888f966a3.diff

LOG: [mlir][Python] Fix the last remaining instance of PYTHON_EXECUTABLE.

* Was causing auto-detect of pybind11 to fail on clean configure.

Differential Revision: https://reviews.llvm.org/D92043

Added: 
    

Modified: 
    mlir/CMakeLists.txt
    mlir/cmake/modules/MLIRDetectPythonEnv.cmake

Removed: 
    


################################################################################
diff  --git a/mlir/CMakeLists.txt b/mlir/CMakeLists.txt
index c10a169640ee..1acdec218373 100644
--- a/mlir/CMakeLists.txt
+++ b/mlir/CMakeLists.txt
@@ -61,7 +61,7 @@ option(MLIR_INCLUDE_INTEGRATION_TESTS
 # Python Bindings Configuration
 # Requires:
 #   The pybind11 library can be found (set with -DPYBIND_DIR=...)
-#   The python executable is correct (set with -DPYTHON_EXECUTABLE=...)
+#   The python executable is correct (set with -DPython3_EXECUTABLE=...)
 #
 # Version locking
 # ---------------

diff  --git a/mlir/cmake/modules/MLIRDetectPythonEnv.cmake b/mlir/cmake/modules/MLIRDetectPythonEnv.cmake
index e3572c37f99e..2a3d1fa1a3c3 100644
--- a/mlir/cmake/modules/MLIRDetectPythonEnv.cmake
+++ b/mlir/cmake/modules/MLIRDetectPythonEnv.cmake
@@ -10,7 +10,7 @@ function(mlir_detect_pybind11_install)
   else()
     message(CHECK_START "Checking for pybind11 in python path...")
     execute_process(
-      COMMAND "${PYTHON_EXECUTABLE}"
+      COMMAND "${Python3_EXECUTABLE}"
       -c "import pybind11;print(pybind11.get_cmake_dir(), end='')"
       WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
       RESULT_VARIABLE STATUS


        


More information about the Mlir-commits mailing list