[Mlir-commits] [mlir] 74207e7 - Fix python bindings tests after change in visibility requirement for symbol declarations

Mehdi Amini llvmlistbot at llvm.org
Mon Nov 16 20:09:44 PST 2020


Author: Mehdi Amini
Date: 2020-11-17T04:09:35Z
New Revision: 74207e78cf26a52a59efaf95104d7ca0e5f801bf

URL: https://github.com/llvm/llvm-project/commit/74207e78cf26a52a59efaf95104d7ca0e5f801bf
DIFF: https://github.com/llvm/llvm-project/commit/74207e78cf26a52a59efaf95104d7ca0e5f801bf.diff

LOG: Fix python bindings tests after change in visibility requirement for symbol declarations

Added: 
    

Modified: 
    mlir/test/Bindings/Python/ir_module.py
    mlir/test/Bindings/Python/ir_operation.py

Removed: 
    


################################################################################
diff  --git a/mlir/test/Bindings/Python/ir_module.py b/mlir/test/Bindings/Python/ir_module.py
index 7a270b8bc33c..abddc66eb47f 100644
--- a/mlir/test/Bindings/Python/ir_module.py
+++ b/mlir/test/Bindings/Python/ir_module.py
@@ -60,12 +60,12 @@ def testCreateEmpty():
 # Note that this does not test that the print path converts unicode properly
 # because MLIR asm always normalizes it to the hex encoding.
 # CHECK-LABEL: TEST: testRoundtripUnicode
-# CHECK: func @roundtripUnicode()
+# CHECK: func private @roundtripUnicode()
 # CHECK: foo = "\F0\9F\98\8A"
 def testRoundtripUnicode():
   ctx = Context()
   module = Module.parse(r"""
-    func @roundtripUnicode() attributes { foo = "😊" }
+    func private @roundtripUnicode() attributes { foo = "😊" }
   """, ctx)
   print(str(module))
 

diff  --git a/mlir/test/Bindings/Python/ir_operation.py b/mlir/test/Bindings/Python/ir_operation.py
index 8827e5dafe2c..16407ca98e68 100644
--- a/mlir/test/Bindings/Python/ir_operation.py
+++ b/mlir/test/Bindings/Python/ir_operation.py
@@ -320,7 +320,7 @@ def testOperationResultList():
       %0:3 = call @f2() : () -> (i32, f64, index)
       return
     }
-    func @f2() -> (i32, f64, index)
+    func private @f2() -> (i32, f64, index)
   """, ctx)
   caller = module.body.operations[0]
   call = caller.regions[0].blocks[0].operations[0]


        


More information about the Mlir-commits mailing list