[Mlir-commits] [mlir] 8e466f6 - [MLIR][NFC] Update syntax of global_memref in ODS description.

[Rahul Joshi]

Author: Rahul Joshi
Date: 2020-11-04T15:58:46-08:00
New Revision: 8e466f69cfaeedbf63e8c643865177bb6e53740c

URL: https://github.com/llvm/llvm-project/commit/8e466f69cfaeedbf63e8c643865177bb6e53740c
DIFF: https://github.com/llvm/llvm-project/commit/8e466f69cfaeedbf63e8c643865177bb6e53740c.diff

LOG: [MLIR][NFC] Update syntax of global_memref in ODS description.

- The ODS description was using an old syntax that was updated during the review.
  This fixes the ODS description to match the current syntax.

Differential Revision: https://reviews.llvm.org/D90797

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/StandardOps/IR/Ops.td b/mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
index 793a441a9c7a..6037b3b32683 100644
--- a/mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
+++ b/mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
@@ -2032,15 +2032,16 @@ def GlobalMemrefOp : Std_Op<"global_memref", [Symbol]> {
 
     ```mlir
     // Private variable with an initial value.
-    global_memref @x : memref<2xf32> { sym_visibility = "private",
-                         initial_value = dense<0.0,2.0> : tensor<2xf32> }
+    global_memref "private" @x : memref<2xf32> = dense<0.0,2.0>
 
-    // External variable.
-    global_memref @y : memref<4xi32> { sym_visibility = "public" }
+    // Declaration of an external variable.
+    global_memref "private" @y : memref<4xi32>
 
     // Uninitialized externally visible variable.
-    global_memref @z : memref<3xf16> { sym_visibility = "public",
-                         initial_value }
+    global_memref @z : memref<3xf16> = uninitialized
+
+    // Externally visibile constant variable.
+    global_memref constant @c : memref<2xi32> = dense<1, 4>
     ```
   }];