[Mlir-commits] [mlir] 0cf5ef1 - Change some extraneous /// comments to // comments inside methods. NFC.

Chris Lattner llvmlistbot at llvm.org
Sun May 31 11:44:14 PDT 2020


Author: Chris Lattner
Date: 2020-05-31T11:43:54-07:00
New Revision: 0cf5ef176b5222b6ee8825a2e4ec843dd7152b46

URL: https://github.com/llvm/llvm-project/commit/0cf5ef176b5222b6ee8825a2e4ec843dd7152b46
DIFF: https://github.com/llvm/llvm-project/commit/0cf5ef176b5222b6ee8825a2e4ec843dd7152b46.diff

LOG: Change some extraneous /// comments to // comments inside methods. NFC.

Added: 
    

Modified: 
    mlir/lib/Transforms/DialectConversion.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Transforms/DialectConversion.cpp b/mlir/lib/Transforms/DialectConversion.cpp
index 4dfb9b1de84a..871252e65e5d 100644
--- a/mlir/lib/Transforms/DialectConversion.cpp
+++ b/mlir/lib/Transforms/DialectConversion.cpp
@@ -877,8 +877,8 @@ void ConversionPatternRewriterImpl::replaceOp(Operation *op,
   // Record the requested operation replacement.
   replacements.emplace_back(op, newValues);
 
-  /// Mark this operation as recursively ignored so that we don't need to
-  /// convert any nested operations.
+  // Mark this operation as recursively ignored so that we don't need to
+  // convert any nested operations.
   markNestedOpsIgnored(op);
 }
 
@@ -1647,13 +1647,13 @@ LogicalResult OperationConverter::convert(ConversionPatternRewriter &rewriter,
   // Legalize the given operation.
   if (failed(opLegalizer.legalize(op, rewriter))) {
     // Handle the case of a failed conversion for each of the 
diff erent modes.
-    /// Full conversions expect all operations to be converted.
+    // Full conversions expect all operations to be converted.
     if (mode == OpConversionMode::Full)
       return op->emitError()
              << "failed to legalize operation '" << op->getName() << "'";
-    /// Partial conversions allow conversions to fail iff the operation was not
-    /// explicitly marked as illegal. If the user provided a nonlegalizableOps
-    /// set, non-legalizable ops are included.
+    // Partial conversions allow conversions to fail iff the operation was not
+    // explicitly marked as illegal. If the user provided a nonlegalizableOps
+    // set, non-legalizable ops are included.
     if (mode == OpConversionMode::Partial) {
       if (opLegalizer.isIllegal(op))
         return op->emitError()
@@ -1663,9 +1663,9 @@ LogicalResult OperationConverter::convert(ConversionPatternRewriter &rewriter,
         trackedOps->insert(op);
     }
   } else {
-    /// Analysis conversions don't fail if any operations fail to legalize,
-    /// they are only interested in the operations that were successfully
-    /// legalized.
+    // Analysis conversions don't fail if any operations fail to legalize,
+    // they are only interested in the operations that were successfully
+    // legalized.
     if (mode == OpConversionMode::Analysis)
       trackedOps->insert(op);
 
@@ -1684,7 +1684,7 @@ OperationConverter::convertOperations(ArrayRef<Operation *> ops,
     return success();
   ConversionTarget &target = opLegalizer.getTarget();
 
-  /// Compute the set of operations and blocks to convert.
+  // Compute the set of operations and blocks to convert.
   std::vector<Operation *> toConvert;
   for (auto *op : ops) {
     toConvert.emplace_back(op);


        


More information about the Mlir-commits mailing list