[Mlir-commits] [mlir] 7fc225f - [mlir] Fix Windows build

[Nicolas Vasilache]

Author: Nicolas Vasilache
Date: 2020-05-29T18:55:21-04:00
New Revision: 7fc225f8c4596d4e51d64e814b21cc49c5e8566b

URL: https://github.com/llvm/llvm-project/commit/7fc225f8c4596d4e51d64e814b21cc49c5e8566b
DIFF: https://github.com/llvm/llvm-project/commit/7fc225f8c4596d4e51d64e814b21cc49c5e8566b.diff

LOG: [mlir] Fix Windows build

Summary:
MSVC does not seem to like certain forward declarations.

https://reviews.llvm.org/D80728 introduces an error where
seemingly unrelated .cpp files that include the .h
(but do not otherwise use the class that depends on the forward declaration).

Instead of forward declaration, include the full vector ops definition.

Subscribers: mehdi_amini, rriddle, jpienaar, shauheen, antiagainst, arpith-jacob, mgester, lucyrfox, aartbik, liufengdb, stephenneuendorffer, Joonsoo, grosul1, frgossen, Kayjukh, jurahul, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D80841

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h b/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
index 2e6a85926079..fb8fc4cbe949 100644
--- a/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
+++ b/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
@@ -10,17 +10,11 @@
 #define DIALECT_LINALG_TRANSFORMS_TRANSFORMS_H_
 
 #include "mlir/Dialect/Linalg/Utils/Utils.h"
+#include "mlir/Dialect/Vector/VectorOps.h"
 #include "mlir/IR/PatternMatch.h"
 #include "llvm/ADT/SmallBitVector.h"
 
 namespace mlir {
-namespace vector {
-
-class TransferReadOp;
-class TransferWriteOp;
-
-} // namespace vector
-
 namespace linalg {
 
 struct LinalgTilingOptions;