[Mlir-commits] [mlir] f88c7fe - [MLIR][cmake][NFC] Update linkage checker for mlir-opt

Stephen Neuendorffer llvmlistbot at llvm.org
Sun May 17 13:58:27 PDT 2020


Author: Stephen Neuendorffer
Date: 2020-05-17T13:46:52-07:00
New Revision: f88c7fe46b37960599e15d373e6ebb0cb2efdc01

URL: https://github.com/llvm/llvm-project/commit/f88c7fe46b37960599e15d373e6ebb0cb2efdc01
DIFF: https://github.com/llvm/llvm-project/commit/f88c7fe46b37960599e15d373e6ebb0cb2efdc01.diff

LOG: [MLIR][cmake][NFC] Update linkage checker for mlir-opt

New CMakeLists.txt for MLIRStandardOpsTransforms was incorrect, but wasn't
caught by the check.

Differential Revision: https://reviews.llvm.org/D80075

Added: 
    

Modified: 
    mlir/cmake/modules/AddMLIR.cmake
    mlir/tools/mlir-opt/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/mlir/cmake/modules/AddMLIR.cmake b/mlir/cmake/modules/AddMLIR.cmake
index b07158ba4d6a..c6ef46823254 100644
--- a/mlir/cmake/modules/AddMLIR.cmake
+++ b/mlir/cmake/modules/AddMLIR.cmake
@@ -179,7 +179,7 @@ function(mlir_check_link_libraries name)
           # same symbol might be loaded from 2 separate libraries.  This
           # often comes from referring to an LLVM library target
           # explicitly in target_link_libraries()
-          message("WARNING: ${l} links LLVM and ${lib}!")
+          message("WARNING: ${name} links LLVM and ${lib}!")
         endif()
       endif()
     endforeach()

diff  --git a/mlir/tools/mlir-opt/CMakeLists.txt b/mlir/tools/mlir-opt/CMakeLists.txt
index 46e7ea69285d..3e8ed0ebee7b 100644
--- a/mlir/tools/mlir-opt/CMakeLists.txt
+++ b/mlir/tools/mlir-opt/CMakeLists.txt
@@ -52,4 +52,4 @@ add_llvm_tool(mlir-opt
 target_link_libraries(mlir-opt PRIVATE ${LIBS})
 llvm_update_compile_flags(mlir-opt)
 
-mlir_check_link_libraries(mlir-opt)
+mlir_check_all_link_libraries(mlir-opt)


        


More information about the Mlir-commits mailing list