[Mlir-commits] [mlir] 7a17f3c - [MLIR] Fix dependencies for Analysis libraries

Stephen Neuendorffer llvmlistbot at llvm.org
Tue May 12 13:41:32 PDT 2020


Author: Stephen Neuendorffer
Date: 2020-05-12T13:41:16-07:00
New Revision: 7a17f3ccd109998d4e7019f5239dda61d7c6f829

URL: https://github.com/llvm/llvm-project/commit/7a17f3ccd109998d4e7019f5239dda61d7c6f829
DIFF: https://github.com/llvm/llvm-project/commit/7a17f3ccd109998d4e7019f5239dda61d7c6f829.diff

LOG: [MLIR] Fix dependencies for Analysis libraries

cmake does not truly support dependencies on automatically generated files
which are not in the same directory as the targets which depend on them.
It works with ninja, but doesn't work with make

This patch adds an explicit dependence so that all dialects are built
before the analysis libraries.

Differential Revision: https://reviews.llvm.org/D79805

Added: 
    

Modified: 
    mlir/lib/Analysis/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Analysis/CMakeLists.txt b/mlir/lib/Analysis/CMakeLists.txt
index a008bcd02468..0d9cc9036c2f 100644
--- a/mlir/lib/Analysis/CMakeLists.txt
+++ b/mlir/lib/Analysis/CMakeLists.txt
@@ -17,6 +17,9 @@ add_mlir_library(MLIRAnalysis
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Analysis
 
+  DEPENDS
+  mlir-headers
+
   LINK_LIBS PUBLIC
   MLIRAffineOps
   MLIRCallInterfaces
@@ -35,6 +38,9 @@ add_mlir_library(MLIRLoopAnalysis
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Analysis
 
+  DEPENDS
+  mlir-headers
+
   LINK_LIBS PUBLIC
   MLIRAffineOps
   MLIRCallInterfaces


        


More information about the Mlir-commits mailing list