[Mlir-commits] [mlir] 84a9c72 - Temporarily Revert "[mlir][shape] Tidy up shape.shape_of" as it's breaking a few tests.
Eric Christopher
llvmlistbot at llvm.org
Mon May 11 23:05:39 PDT 2020
Author: Eric Christopher
Date: 2020-05-11T23:05:18-07:00
New Revision: 84a9c725742d26df04808a3c7349dbd98684c6cb
URL: https://github.com/llvm/llvm-project/commit/84a9c725742d26df04808a3c7349dbd98684c6cb
DIFF: https://github.com/llvm/llvm-project/commit/84a9c725742d26df04808a3c7349dbd98684c6cb.diff
LOG: Temporarily Revert "[mlir][shape] Tidy up shape.shape_of" as it's breaking a few tests.
This reverts commit b6045448869a63dc7da3a4c87c124e85101220d7.
Followed up offline with a testcase.
Added:
Modified:
mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
mlir/test/Dialect/Shape/ops.mlir
Removed:
################################################################################
diff --git a/mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td b/mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
index 3753213f9ab3..6b64bb78bb85 100644
--- a/mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
+++ b/mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
@@ -226,14 +226,12 @@ def Shape_ReduceOp : Shape_Op<"reduce", []> {
}
def Shape_ShapeOfOp : Shape_Op<"shape_of",
- [NoSideEffect, DeclareOpInterfaceMethods<InferTypeOpInterface>]> {
+ [DeclareOpInterfaceMethods<InferTypeOpInterface>]> {
let summary = "Returns shape of a value or shaped type operand";
let arguments = (ins AnyTypeOf<[AnyShaped, Shape_ValueShapeType]>:$arg);
let results = (outs Shape_ShapeType:$result);
- let assemblyFormat = "attr-dict $arg `:` type($arg)";
-
let hasFolder = 1;
}
diff --git a/mlir/test/Dialect/Shape/ops.mlir b/mlir/test/Dialect/Shape/ops.mlir
index 81c9afceef5f..5ca3b0f49120 100644
--- a/mlir/test/Dialect/Shape/ops.mlir
+++ b/mlir/test/Dialect/Shape/ops.mlir
@@ -62,8 +62,3 @@ func @test_parse_const_shape() {
%1 = shape.const_shape [1, 2, 3]
return
}
-
-func @test_shape_of(%arg0: tensor<?xf32>) -> !shape.shape {
- %0 = shape.shape_of %arg0 : tensor<?xf32>
- return %0 : !shape.shape
-}
More information about the Mlir-commits
mailing list