[Mlir-commits] [mlir] f240d30 - [mlir] Explicitly qualify Effect to avoid MSVC build failure

[River Riddle]

Author: River Riddle
Date: 2020-03-06T19:18:13-08:00
New Revision: f240d303c2edf69d6a53691c62da110877ac6bf5

URL: https://github.com/llvm/llvm-project/commit/f240d303c2edf69d6a53691c62da110877ac6bf5
DIFF: https://github.com/llvm/llvm-project/commit/f240d303c2edf69d6a53691c62da110877ac6bf5.diff

LOG: [mlir] Explicitly qualify Effect to avoid MSVC build failure

MSVC qualifies the Effect reference contextually depending on where the
template is instantiated, leading to compiler failures if there is a
different Effect class defined.

Added: 
    

Modified: 
    mlir/include/mlir/IR/OpDefinition.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/IR/OpDefinition.h b/mlir/include/mlir/IR/OpDefinition.h
index fe94f256035a..a279843cf0a4 100644
--- a/mlir/include/mlir/IR/OpDefinition.h
+++ b/mlir/include/mlir/IR/OpDefinition.h
@@ -1301,7 +1301,7 @@ class Effect {
     static ClassID *getEffectID() { return ClassID::getID<DerivedEffect>(); }
 
     /// 'classof' used to support llvm style cast functionality.
-    static bool classof(const Effect *effect) {
+    static bool classof(const ::mlir::SideEffects::Effect *effect) {
       return effect->getEffectID() == BaseT::getEffectID();
     }