[Mlir-commits] [mlir] c19fae5 - [mlir] [VectorOps] Add missing comments to CreateMaskOp lowering

[llvmlistbot at llvm.org]

Author: aartbik
Date: 2020-06-04T12:50:47-07:00
New Revision: c19fae507e311723b40a0cafa17d4e48b1664fb9

URL: https://github.com/llvm/llvm-project/commit/c19fae507e311723b40a0cafa17d4e48b1664fb9
DIFF: https://github.com/llvm/llvm-project/commit/c19fae507e311723b40a0cafa17d4e48b1664fb9.diff

LOG: [mlir] [VectorOps] Add missing comments to CreateMaskOp lowering

Summary: Add missing comment to CreateMask. Fixed typo in ConstantMask comment.

Reviewers: nicolasvasilache, rriddle, reidtatge, ftynse

Reviewed By: ftynse

Subscribers: mehdi_amini, rriddle, jpienaar, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, stephenneuendorffer, Joonsoo, grosul1, frgossen, Kayjukh, jurahul

Tags: #mlir

Differential Revision: https://reviews.llvm.org/D81125

Added: 
    

Modified: 
    mlir/lib/Dialect/Vector/VectorTransforms.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/Vector/VectorTransforms.cpp b/mlir/lib/Dialect/Vector/VectorTransforms.cpp
index 82c27387bd6e..99a3a951e9de 100644
--- a/mlir/lib/Dialect/Vector/VectorTransforms.cpp
+++ b/mlir/lib/Dialect/Vector/VectorTransforms.cpp
@@ -1304,10 +1304,10 @@ class OuterProductOpLowering : public OpRewritePattern<vector::OuterProductOp> {
 
 /// Progressive lowering of ConstantMaskOp.
 /// One:
-///   %x = vector.constant_mask_op [a,b]
+///   %x = vector.constant_mask [a,b]
 /// is replaced by:
 ///   %z = zero-result
-///   %l = vector.constant_mask_op [b]
+///   %l = vector.constant_mask [b]
 ///   %4 = vector.insert %l, %z[0]
 ///   ..
 ///   %x = vector.insert %l, %..[a-1]
@@ -1351,6 +1351,17 @@ class ConstantMaskOpLowering : public OpRewritePattern<vector::ConstantMaskOp> {
   }
 };
 
+/// Progressive lowering of CreateMaskOp.
+/// One:
+///   %x = vector.create_mask %a, ... : vector<dx...>
+/// is replaced by:
+///   %l = vector.create_mask ... : vector<...>  ; one lower rank
+///   %0 = cmpi "slt", %ci, %a       |
+///   %1 = select %0, %l, %zeroes    |
+///   %r = vector.insert %1, %pr [i] | d-times
+///   %x = ....
+/// When rank == 1, the selection operator is not needed,
+/// and we can assign the true/false value right away.
 class CreateMaskOpLowering : public OpRewritePattern<vector::CreateMaskOp> {
 public:
   using OpRewritePattern<vector::CreateMaskOp>::OpRewritePattern;