[Mlir-commits] [mlir] abd6574 - Add missing CMake bool canonicalizations.

Stella Laurenzo llvmlistbot at llvm.org
Wed Jul 8 20:18:00 PDT 2020


Author: Stella Laurenzo
Date: 2020-07-08T17:56:48-07:00
New Revision: abd6574b4542958bbde0d5b9568598f32417ef0a

URL: https://github.com/llvm/llvm-project/commit/abd6574b4542958bbde0d5b9568598f32417ef0a
DIFF: https://github.com/llvm/llvm-project/commit/abd6574b4542958bbde0d5b9568598f32417ef0a.diff

LOG: Add missing CMake bool canonicalizations.

Summary:
* This allows these flags to be passed on the command line with normal CMake bool-interpreted values like ON/OFF instead of requiring 0/1.
* As-is, if passing ON/OFF, these will cause a parse error in lit.site.cfg.py because Python tries to interpret the string literally.

Reviewers: stephenneuendorffer

Subscribers: mgorny, mehdi_amini, rriddle, jpienaar, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, aartbik, liufengdb, Joonsoo, grosul1, Kayjukh, jurahul, msifontes

Tags: #mlir

Differential Revision: https://reviews.llvm.org/D83451

Added: 
    

Modified: 
    mlir/test/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/mlir/test/CMakeLists.txt b/mlir/test/CMakeLists.txt
index 7c06bd740773..a2d9e2d06228 100644
--- a/mlir/test/CMakeLists.txt
+++ b/mlir/test/CMakeLists.txt
@@ -5,6 +5,11 @@ add_subdirectory(lib)
 
 llvm_canonicalize_cmake_booleans(
   LLVM_BUILD_EXAMPLES
+  MLIR_CUDA_CONVERSIONS_ENABLED
+  MLIR_CUDA_RUNNER_ENABLED
+  MLIR_ROCM_CONVERSIONS_ENABLED
+  MLIR_ROCM_RUNNER_ENABLED
+  MLIR_VULKAN_RUNNER_ENABLED
   )
 
 # Passed to lit.site.cfg.py.in to set up the path where to find the libraries


        


More information about the Mlir-commits mailing list