[Mlir-commits] [mlir] 3ac37eb - Silence compiler warnings

[Benjamin Kramer]

Author: Benjamin Kramer
Date: 2020-02-24T11:45:59+01:00
New Revision: 3ac37eb9a93a4009f58c29497aa141fc103f4c45

URL: https://github.com/llvm/llvm-project/commit/3ac37eb9a93a4009f58c29497aa141fc103f4c45
DIFF: https://github.com/llvm/llvm-project/commit/3ac37eb9a93a4009f58c29497aa141fc103f4c45.diff

LOG: Silence compiler warnings

mlir/lib/Parser/Parser.cpp:4484:15: warning: 'parseAssignmentList' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
  ParseResult parseAssignmentList(SmallVectorImpl<OperandType> &lhs,
              ^
mlir/include/mlir/IR/OpImplementation.h:662:3: note: overridden virtual function is here
  parseAssignmentList(SmallVectorImpl<OperandType> &lhs,
  ^
mlir/lib/Parser/Parser.cpp:4488:12: warning: unused variable 'type' [-Wunused-variable]
      Type type;
           ^

Added: 
    

Modified: 
    mlir/lib/Parser/Parser.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Parser/Parser.cpp b/mlir/lib/Parser/Parser.cpp
index 3929cdd10a97..03c676f905d4 100644
--- a/mlir/lib/Parser/Parser.cpp
+++ b/mlir/lib/Parser/Parser.cpp
@@ -4482,10 +4482,9 @@ class CustomOpAsmParser : public OpAsmParser {
   /// (%x1 = %y1 : type1, %x2 = %y2 : type2, ...).
   /// The list must contain at least one entry
   ParseResult parseAssignmentList(SmallVectorImpl<OperandType> &lhs,
-                                  SmallVectorImpl<OperandType> &rhs) {
+                                  SmallVectorImpl<OperandType> &rhs) override {
     auto parseElt = [&]() -> ParseResult {
       OperandType regionArg, operand;
-      Type type;
       if (parseRegionArgument(regionArg) || parseEqual() ||
           parseOperand(operand))
         return failure();