[Mlir-commits] [mlir] 10382eb - [mlir][Linalg] Fix build warnings

[Nicolas Vasilache]

Author: Nicolas Vasilache
Date: 2020-02-12T16:50:40-05:00
New Revision: 10382ebe8f3f8e5df3b163fc0026b300d6274b2c

URL: https://github.com/llvm/llvm-project/commit/10382ebe8f3f8e5df3b163fc0026b300d6274b2c
DIFF: https://github.com/llvm/llvm-project/commit/10382ebe8f3f8e5df3b163fc0026b300d6274b2c.diff

LOG: [mlir][Linalg] Fix build warnings

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
    mlir/lib/Dialect/Linalg/EDSC/Builders.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td b/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
index 8914bcfe546b..09a85a1026fb 100644
--- a/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
+++ b/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
@@ -330,6 +330,8 @@ def FillOp : LinalgStructured_Op<"fill", [NInputs<0>, NOutputs<1>]> {
       llvm_unreachable("NYI referenceIndexingMaps for CopyOp");
     }
   }];
+  let verifier = [{ return ::verify(*this); }];
+  
   let hasFolder = 1;
 }
 

diff  --git a/mlir/lib/Dialect/Linalg/EDSC/Builders.cpp b/mlir/lib/Dialect/Linalg/EDSC/Builders.cpp
index 25d6091f9fed..e2c64f050158 100644
--- a/mlir/lib/Dialect/Linalg/EDSC/Builders.cpp
+++ b/mlir/lib/Dialect/Linalg/EDSC/Builders.cpp
@@ -205,13 +205,6 @@ Operation *mlir::edsc::makeGenericLinalgOp(
   return op;
 }
 
-static void mulRegionBuilder(ArrayRef<BlockArgument> args) {
-  using edsc::op::operator*;
-  assert(args.size() == 2 && "expected 2 block arguments");
-  ValueHandle a(args[0]), b(args[1]);
-  linalg_yield((a * b).getValue());
-}
-
 void mlir::edsc::ops::mulRegionBuilder(ArrayRef<BlockArgument> args) {
   using edsc::op::operator+;
   using edsc::op::operator*;