[Mlir-commits] [mlir] 0e70a12 - [mlir][linalg][NFC] Remove extra semi-colon causing warnings
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Wed Aug 12 08:44:40 PDT 2020
Author: Valentin Clement
Date: 2020-08-12T11:44:30-04:00
New Revision: 0e70a127a942ee28c50391ff1198b0928c7d1597
URL: https://github.com/llvm/llvm-project/commit/0e70a127a942ee28c50391ff1198b0928c7d1597
DIFF: https://github.com/llvm/llvm-project/commit/0e70a127a942ee28c50391ff1198b0928c7d1597.diff
LOG: [mlir][linalg][NFC] Remove extra semi-colon causing warnings
Extra semi-colon causes bunch of warnings with GCC 9.2.0
```
[1354/1516] Building CXX object tools/mlir/lib/Dialect/Linalg/IR/CMakeFiles/obj.MLIRLinalgOps.dir/LinalgOps.cpp.o
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1306:35: warning: extra ';' [-Wpedantic]
1306 | CANONICALIZERS_AND_FOLDERS(ConvOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1307:41: warning: extra ';' [-Wpedantic]
1307 | CANONICALIZERS_AND_FOLDERS(PoolingMaxOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1308:41: warning: extra ';' [-Wpedantic]
1308 | CANONICALIZERS_AND_FOLDERS(PoolingMinOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1309:41: warning: extra ';' [-Wpedantic]
1309 | CANONICALIZERS_AND_FOLDERS(PoolingSumOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1310:35: warning: extra ';' [-Wpedantic]
1310 | CANONICALIZERS_AND_FOLDERS(CopyOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1311:35: warning: extra ';' [-Wpedantic]
1311 | CANONICALIZERS_AND_FOLDERS(FillOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1312:38: warning: extra ';' [-Wpedantic]
1312 | CANONICALIZERS_AND_FOLDERS(GenericOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1313:45: warning: extra ';' [-Wpedantic]
1313 | CANONICALIZERS_AND_FOLDERS(IndexedGenericOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1318:42: warning: extra ';' [-Wpedantic]
1318 | CANONICALIZERS_AND_FOLDERS(BatchMatmulOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1319:34: warning: extra ';' [-Wpedantic]
1319 | CANONICALIZERS_AND_FOLDERS(DotOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1320:37: warning: extra ';' [-Wpedantic]
1320 | CANONICALIZERS_AND_FOLDERS(MatmulOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1321:37: warning: extra ';' [-Wpedantic]
1321 | CANONICALIZERS_AND_FOLDERS(MatvecOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1322:36: warning: extra ';' [-Wpedantic]
1322 | CANONICALIZERS_AND_FOLDERS(ConvWOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1323:38: warning: extra ';' [-Wpedantic]
1323 | CANONICALIZERS_AND_FOLDERS(ConvNWCOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1324:38: warning: extra ';' [-Wpedantic]
1324 | CANONICALIZERS_AND_FOLDERS(ConvNCWOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1325:37: warning: extra ';' [-Wpedantic]
1325 | CANONICALIZERS_AND_FOLDERS(ConvHWOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1326:39: warning: extra ';' [-Wpedantic]
1326 | CANONICALIZERS_AND_FOLDERS(ConvNHWCOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1327:39: warning: extra ';' [-Wpedantic]
1327 | CANONICALIZERS_AND_FOLDERS(ConvNCHWOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1328:38: warning: extra ';' [-Wpedantic]
1328 | CANONICALIZERS_AND_FOLDERS(ConvDHWOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1329:40: warning: extra ';' [-Wpedantic]
1329 | CANONICALIZERS_AND_FOLDERS(ConvNDHWCOp);
| ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1330:40: warning: extra ';' [-Wpedantic]
1330 | CANONICALIZERS_AND_FOLDERS(ConvNCDHWOp);
| ^
```
Reviewed By: mehdi_amini, rriddle
Differential Revision: https://reviews.llvm.org/D85766
Added:
Modified:
mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
Removed:
################################################################################
diff --git a/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp b/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
index a8d98af2ce40..009699be5263 100644
--- a/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
+++ b/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
@@ -1303,28 +1303,28 @@ struct EraseDeadLinalgOp : public RewritePattern {
return foldMemRefCast(*this); \
}
-CANONICALIZERS_AND_FOLDERS(ConvOp);
-CANONICALIZERS_AND_FOLDERS(PoolingMaxOp);
-CANONICALIZERS_AND_FOLDERS(PoolingMinOp);
-CANONICALIZERS_AND_FOLDERS(PoolingSumOp);
-CANONICALIZERS_AND_FOLDERS(CopyOp);
-CANONICALIZERS_AND_FOLDERS(FillOp);
-CANONICALIZERS_AND_FOLDERS(GenericOp);
-CANONICALIZERS_AND_FOLDERS(IndexedGenericOp);
+CANONICALIZERS_AND_FOLDERS(ConvOp)
+CANONICALIZERS_AND_FOLDERS(PoolingMaxOp)
+CANONICALIZERS_AND_FOLDERS(PoolingMinOp)
+CANONICALIZERS_AND_FOLDERS(PoolingSumOp)
+CANONICALIZERS_AND_FOLDERS(CopyOp)
+CANONICALIZERS_AND_FOLDERS(FillOp)
+CANONICALIZERS_AND_FOLDERS(GenericOp)
+CANONICALIZERS_AND_FOLDERS(IndexedGenericOp)
#include "mlir/Dialect/Linalg/IR/LinalgNamedStructuredOps.cpp.inc"
// TODO: Determine whether we can generate the folders and verifiers.
-CANONICALIZERS_AND_FOLDERS(BatchMatmulOp);
-CANONICALIZERS_AND_FOLDERS(DotOp);
-CANONICALIZERS_AND_FOLDERS(MatmulOp);
-CANONICALIZERS_AND_FOLDERS(MatvecOp);
-CANONICALIZERS_AND_FOLDERS(ConvWOp);
-CANONICALIZERS_AND_FOLDERS(ConvNWCOp);
-CANONICALIZERS_AND_FOLDERS(ConvNCWOp);
-CANONICALIZERS_AND_FOLDERS(ConvHWOp);
-CANONICALIZERS_AND_FOLDERS(ConvNHWCOp);
-CANONICALIZERS_AND_FOLDERS(ConvNCHWOp);
-CANONICALIZERS_AND_FOLDERS(ConvDHWOp);
-CANONICALIZERS_AND_FOLDERS(ConvNDHWCOp);
-CANONICALIZERS_AND_FOLDERS(ConvNCDHWOp);
+CANONICALIZERS_AND_FOLDERS(BatchMatmulOp)
+CANONICALIZERS_AND_FOLDERS(DotOp)
+CANONICALIZERS_AND_FOLDERS(MatmulOp)
+CANONICALIZERS_AND_FOLDERS(MatvecOp)
+CANONICALIZERS_AND_FOLDERS(ConvWOp)
+CANONICALIZERS_AND_FOLDERS(ConvNWCOp)
+CANONICALIZERS_AND_FOLDERS(ConvNCWOp)
+CANONICALIZERS_AND_FOLDERS(ConvHWOp)
+CANONICALIZERS_AND_FOLDERS(ConvNHWCOp)
+CANONICALIZERS_AND_FOLDERS(ConvNCHWOp)
+CANONICALIZERS_AND_FOLDERS(ConvDHWOp)
+CANONICALIZERS_AND_FOLDERS(ConvNDHWCOp)
+CANONICALIZERS_AND_FOLDERS(ConvNCDHWOp)
More information about the Mlir-commits
mailing list