[llvm-testresults] Red bots at night, buildczar's delight?
dalej
dalej at apple.com
Wed Nov 17 11:33:36 PST 2010
On Nov 17, 2010, at 10:39 AM, dalej wrote:
>>>> clang-i386-darwin10 running the gcc testsuite developed 5 new failures (there are others, claimed by Rafael but not fixed) in the range 119343-119345 (build 1625). That's Chandler and John; all the patches look unrelated to the failures to me, but obviously one of them isn't.
John analyzed this as:
>>> gcc.apple/default-x86_64-sse3.c has:
>>> #include <pmmintrin.h>
...which eventually includes <mm_malloc.h>, a gcc-supplied header....
>>> gcc's mm_malloc.h has:
>>> #include <stdlib.h>
>>>
>>> After r119343, Clang's mm_malloc.h has:
>>> #include <stddef.h>
>>>
>>> The test case contains a (spurious) call to exit(). Cue clang warning about exit() not being declared and dejagnu complaining about extra "errors".
I said:
> there's no reason <pmmintrin.h> should declare exit. Test is broken, I'll fix.
but on further consideration I'm not so sure. gcc's *mmintrin.h files have been (indirectly) including <stdlib.h> forever, at least since 2004, and use of those headers is widespread in X86 code. Removing <stdlib.h> breaks these 5 tests, and may well break user code. I don't think these headers are covered by any standard, but I'm not seeing a good reason to break compatibility with gcc in this way. Chandler, why did you do this? Other opinions?
More information about the llvm-testresults
mailing list