[llvm-dev] Preparing BOLT for LLVM monorepo

[Eric Christopher via llvm-dev]

On Wed, Nov 3, 2021 at 2:37 AM Maksim Panchenko <maks at fb.com> wrote:

> > Making sure things are LLVM coding style, format, etc are pretty
>
> > important to me. flang was a useful pilot here in a lot of ways and some
>
> > of the requests for fixups still don't really seem to have happened so
>
> > making sure that happens before is pretty important to me.
>
>
>
> Following someone's footsteps has its drawbacks too :) Fair enough. We
>
> continue to develop BOLT and have plans for more tight integration with
>
> LLVM, such as sharing the common binary IR. Having a clean and
>
> easy-to-read codebase will be highly beneficial to the community.
>
>
>

Excellent. Looking forward to the code review!


> >> We haven't made the final decision on including BOLT in
>
> >> LLVM_ALL_PROJECTS, but we are ready to make BOLT the default project in
>
> >> the initial merge commit. Currently, we do not support building on
>
> >> Windows; thus, the project will be automatically disabled with the
>
> >> warning when building on unsupported platforms. As we anticipate the
>
> >
>
> > Oh? Build or work? And why :)
>
>
>
> The Windows build was disabled due to the usage of threads, IIRC.
>
> Although, we don't use them directly, only via the C++11 standard
>
> library. I don't have access to a windows box to test it myself. If the
>
> build issues are resolved, I don't see why BOLT can't be used to
>
> optimize ELF binaries on windows.
>
>
>

Makes sense. Might be good to just disable threads on windows rather than
disabling the build also.

Thanks for the response!

-eric


> Thanks!
>
> Maksim
>
>
>
> On 11/2/21, 3:15 PM, "Eric Christopher" <echristo at gmail.com> wrote:
>
>
>
> Hi Maksim,
>
>
>
> I think this sounds great in general.
>
>
>
> Making sure things are LLVM coding style, format, etc are pretty important
> to me. flang was a useful pilot here in a lot of ways and some of the
> requests for fixups still don't really seem to have happened so making sure
> that happens before is pretty important to me.
>
>
>
> One inline question:
>
>
>
> We haven't made the final decision on including BOLT in
>
> LLVM_ALL_PROJECTS, but we are ready to make BOLT the default project in
>
> the initial merge commit. Currently, we do not support building on
>
> Windows; thus, the project will be automatically disabled with the
>
> warning when building on unsupported platforms. As we anticipate the
>
>
>
>
>
> Oh? Build or work? And why :)
>
>
>
> Thanks and good luck!
>
>
>
> -eric
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20211103/2300e1b4/attachment-0001.html>