[llvm-dev] Sign up to phab, authorize 'r4nt'?

Manuel Klimek via llvm-dev llvm-dev at lists.llvm.org
Mon May 10 09:53:30 PDT 2021 

On Mon, May 10, 2021 at 5:27 PM Mehdi AMINI <joker.eph at gmail.com> wrote:

>
>
> On Mon, May 10, 2021 at 4:58 AM Manuel Klimek <klimek at google.com> wrote:
>
>>
>> I think any user with admin access and LLVM github access can go into
>> phab's "Auth" app, and edit the github auth provider with a new App ID and
>> secret, right?
>>
>
> Yes, but that would require everyone to re-authorize the new application
> on GitHub, while if you transfer the application on GitHub side, it'll
> become part of the LLVM organization with the existing token and (I think)
> it will "keep the lights on".
>

Oooh, cool, wasn't aware that works. Tom, do you want to set up a meeting
for us? What time works for you? (I'm CEST)


>
> --
> Mehdi
>
>
>
>>
>> On Sat, May 8, 2021 at 5:36 AM Tom Stellard <tstellar at redhat.com> wrote:
>>
>>> On 5/7/21 6:01 PM, Mehdi AMINI wrote:
>>> >
>>> >
>>> > On Fri, May 7, 2021 at 3:29 PM Tom Stellard <tstellar at redhat.com
>>> <mailto:tstellar at redhat.com>> wrote:
>>> >
>>> >     On 5/7/21 8:56 AM, Mehdi AMINI wrote:
>>> >      >
>>> >      >
>>> >      > On Fri, May 7, 2021 at 8:45 AM Tom Stellard <
>>> tstellar at redhat.com <mailto:tstellar at redhat.com> <mailto:
>>> tstellar at redhat.com <mailto:tstellar at redhat.com>>> wrote:
>>> >      >
>>> >      >     On 5/6/21 8:37 PM, Mehdi AMINI wrote:
>>> >      >      > Hi,
>>> >      >      >
>>> >      >      > GitHub allows to "transfer ownership" for such
>>> applications, we should likely transfer this to the LLVM account ideally. I
>>> don't know who can coordinate this with Manuel, maybe Tom or Mike?
>>> >      >      >
>>> >      >
>>> >      >     Is phabricator actually using r4nt's github account or is
>>> >      >     r4nt just part of the description of our phabricator
>>> instance?
>>> >      >
>>> >      >
>>> >      > The oAuth application is owned by r4nt's GitHub account I
>>> believe:
>>> https://docs.github.com/en/developers/apps/authorizing-oauth-apps <
>>> https://docs.github.com/en/developers/apps/authorizing-oauth-apps> <
>>> https://docs.github.com/en/developers/apps/authorizing-oauth-apps <
>>> https://docs.github.com/en/developers/apps/authorizing-oauth-apps>>
>>> >      >
>>> >      > Phab does not reference r4nt, it just has the token for the
>>> oAuth application. When a user wants to login on Phab for the first time,
>>> they are redirected to GitHub itself to "grant permission" to r4nt to log
>>> them in on Phab (this is the message in the original email in this thread).
>>> >      >
>>> >
>>> >     OK, that make sense.  Where is the OAuth app phabricator is using?
>>> >     Is it on GitHub somewhere?  I don't see anything in r4nt's
>>> repositories
>>> >     that looks like an OAuth app.
>>> >
>>> >
>>> > This isn't public like a repo, each user can manage their own in
>>> https://github.com/settings/developers <
>>> https://github.com/settings/developers>
>>> >
>>>
>>> Ok, I'll try to coordinate this with Manuel.
>>>
>>> -Tom
>>>
>>> > --
>>> > Mehdi
>>> >
>>> >
>>> >
>>> >     -Tom
>>> >
>>> >      > --
>>> >      > Mehdi
>>> >      >
>>> >      >
>>> >      >     -Tom
>>> >      >
>>> >      >      > --
>>> >      >      > Mehdi
>>> >      >      >
>>> >      >      >
>>> >      >      > On Thu, May 6, 2021 at 7:39 PM Geoffrey Martin-Noble via
>>> llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>
>>> <mailto:llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>
>>> <mailto:llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>
>>> <mailto:llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>>>
>>> wrote:
>>> >      >      >
>>> >      >      >     r4nt is the github username of +Manuel Klimek
>>> <mailto:klimek at google.com <mailto:klimek at google.com> <mailto:
>>> klimek at google.com <mailto:klimek at google.com>>>, who I'm guessing set up
>>> the integration
>>> >      >      >
>>> >      >      >     On Thu, May 6, 2021 at 7:12 PM Jon Chesterfield via
>>> llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>
>>> <mailto:llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>
>>> <mailto:llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>
>>> <mailto:llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>>>
>>> wrote:
>>> >      >      >
>>> >      >      >         A colleague just went to sign up to llvm reviews
>>> using a github account. From https:/reviews.llvm.org/login/?next= <
>>> http://reviews.llvm.org/login/?next=> <
>>> http://reviews.llvm.org/login/?next= <
>>> http://reviews.llvm.org/login/?next=>> <
>>> http://reviews.llvm.org/login/?next= <
>>> http://reviews.llvm.org/login/?next=> <
>>> http://reviews.llvm.org/login/?next= <
>>> http://reviews.llvm.org/login/?next=>>> which looks normal, goes to a
>>> page saying:
>>> >      >      >
>>> >      >      >         Authorize LLVM Reviews
>>> >      >      >         LLVM Reviews by r4nt
>>> >      >      >         wants to access your $username account
>>> >      >      >
>>> >      >      >         Green button saying `Authorize r4nt`
>>> >      >      >
>>> >      >      >         So, who's r4nt, and is this expected behaviour?
>>> >      >      >
>>> >      >      >         Cheers
>>> >      >      >         _______________________________________________
>>> >      >      >         LLVM Developers mailing list
>>> >      >      > llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>
>>> <mailto:llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>
>>> <mailto:llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>
>>> <mailto:llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>>
>>> >      >      > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>> <https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev> <
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev <
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev>> <
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev <
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev> <
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev <
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev>>>
>>> >      >      >
>>> >      >      >     _______________________________________________
>>> >      >      >     LLVM Developers mailing list
>>> >      >      > llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>
>>> <mailto:llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>
>>> <mailto:llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>
>>> <mailto:llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>>>
>>> >      >      > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>> <https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev> <
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev <
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev>> <
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev <
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev> <
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev <
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev>>>
>>> >      >      >
>>> >      >
>>> >
>>>
>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210510/8505dc48/attachment.html>

More information about the llvm-dev mailing list