[llvm-dev] Patch for LLVM-C?

[Tom Stellard via llvm-dev]

On 6/24/21 12:17 PM, Armin Hamar wrote:
> I would like to but i don’t have a bugzilla account and requesting seems the be not possible (email doesn’t get send as it’s rejected by the server).
> 
> So for me there isn’t really a way to file this in. I did send it directly to admin at lists.llvm.org ..
> 

I just had a chance to review the patch, and it is very straightforward,
so I went ahead and backported it.  No need to file a bug now.

-Tom

>> Am 24.06.2021 um 20:52 schrieb Tom Stellard <tstellar at redhat.com>:
>>
>> On 6/24/21 10:56 AM, Armin Hamar wrote:
>>> Hello 👋🏻
>>> I have a little problem with the current llvm-c version it seems like it is not possible to use it correctly?
>>
>> Can you file a bug for this an put release-12.0.1 in the 'blocks' field.
>>
>> -Tom
>>
>>> The reason is that byval and sret seem to require a type attribute which can’t be created in the C api. Someone already wrote a fix for it and that is already in the main repo but it didn’t make it into llvm12. This wasn’t a real problem with llvm11 but now is at it seems to be required for functions to actually work.
>>> This is the commit that allows one to make these TypeAttributes:
>>> https://github.com/llvm/llvm-project/commit/528f6f7d617757addac9b51dd5bcc1ab1352e9be <https://github.com/llvm/llvm-project/commit/528f6f7d617757addac9b51dd5bcc1ab1352e9be>
>>> My request is now to add this as a patch to llvm-c for version 12 if this can be done quicker than a new llvm version (e.g 13). The commit also doesn’t edit anything that’s already there but just adds new functions for type attributes. Almost seems like it slipped under the radar.
>>> Best regards,
>>> Armin Hamar
>>
>