[llvm-dev] "[NFC]" Abuse

David Blaikie via llvm-dev llvm-dev at lists.llvm.org
Thu Jun 24 11:25:34 PDT 2021

On Thu, Jun 24, 2021 at 11:23 AM John McCall <rjmccall at apple.com> wrote:

> On 24 Jun 2021, at 13:35, David Blaikie wrote:
> > On Wed, Jun 23, 2021 at 2:57 PM John McCall <rjmccall at apple.com> wrote:
> >> Ah, no, I meant you, but I wrote it out completely wrong: I meant
> >> that it feels like the people using NFC this broadly almost mean
> >> that a patch *not* being NFC makes it especially questionable
> >> and then are looking for nearly any reason to mark it NFC.
> >>
> > That's not so much my feeling, I think - NFC versus non-NFC for me is
> > mostly an indicator of how I should review the patch. Usually hinging on
> > "does this have tests/is this testable".
> Okay.  Well, we use NFC differently, but because I use it more strictly,
> at least I won’t bother you.

I mean, a little - If I end up reading the patch, seeing no tests &
wondering why it's not tested & have to understand more about the patch to
see it's changing something that doesn't need test coverage.

But not the biggest deal, no.

- Dave
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210624/03e28bfb/attachment.html>

More information about the llvm-dev mailing list