[llvm-dev] "[NFC]" Abuse

Joerg Sonnenberger via llvm-dev llvm-dev at lists.llvm.org
Sun Jun 20 16:41:25 PDT 2021

On Thu, Jun 17, 2021 at 03:13:16PM -0400, John McCall via llvm-dev wrote:
> Yeah, I expect NFC changes to be purely internal implementation
> details.  Changing the public interface (even to add a feature)
> isn’t NFC; neither is anything that can affect output.

I would consider an even more restricted subset: NFC changes would be
trivial proven to be just that. That means non-trivial algorithmic
changes are certainly not NFC. My point is that the tag should be
applied with care only and if there is any doubt, it should not be used
at all.


More information about the llvm-dev mailing list