[llvm-dev] "[NFC]" Abuse

[Luke Drummond via llvm-dev]

On Thu Jun 17, 2021 at 7:48 PM BST, Fangrui Song via llvm-dev wrote:
> Sometimes people use the term "NFCI" (no functional change intended).
> I thought "intended" means that: the author is not 100% sure that no
> functional change is caused (for some refactoring it is sometimes
> difficult to guarantee without good test coverage)
> but seems that many use "NFCI" to refer to obviously NFC things.

This is my understanding too. Even said - I still don't think this can ever
apply to function signature changes as you suggest:
> I consider anything modifying an external function/variable (e.g. adding a
> parameter, changing the state of a default argument, deleting an unused
> function, etc) a functional change.

All the Best

Luke

-- 
Codeplay Software Ltd.
Company registered in England and Wales, number: 04567874
Registered office: Regent House, 316 Beulah Hill, London, SE19 3HF
On Thu Jun 17, 2021 at 7:48 PM BST, Fangrui Song via llvm-dev wrote: