[llvm-dev] Buildbot blamelist does not include committer

Tue Jul 13 23:10:56 PDT 2021

I noticed for the following notification I was the only person in CC.
But the commit was updated and committed by another person. I am an
author of the commit, but committer is different.
I think it may be useful to include committers into the blame list as
well. What do you think?

On Wed, 14 Jul 2021 at 08:01, <llvm.buildmaster at lab.llvm.org> wrote:
>
> The Buildbot has detected a failed build on builder sanitizer-windows while building compiler-rt.
>
> Full details are available at:
>     https://lab.llvm.org/buildbot#builders/127/builds/13871
>
> Worker for this Build: sanitizer-windows
> Blamelist:
>     Dmitry Vyukov <dvyukov at google.com>
>
> BUILD FAILED: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/sanitizer-windows.py ...'
>
> Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/sanitizer-windows.py ...'
> python ../llvm-zorg/zorg/buildbot/builders/annotated/sanitizer-windows.py --jobs=16
>  in dir C:\b\slave\sanitizer-windows\build (timeout 1200 secs)
>  watching logfiles {}
>  argv: ['python', '../llvm-zorg/zorg/buildbot/builders/annotated/sanitizer-windows.py', '--jobs=16']
>  environment:
>   ALLUSERSPROFILE=C:\ProgramData
>   APPDATA=C:\Users\buildbot\AppData\Roaming
>   BUILDBOT_BLAMELIST=[]
>   BUILDBOT_BRANCH=main
>   BUILDBOT_BUILDERNAME=sanitizer-windows
>   BUILDBOT_BUILDNUMBER=13871
>   BUILDBOT_CLOBBER=
>   BUILDBOT_GOT_REVISION=dfd9808b6cea59ff075498ee7e6e57f2b5b3a798
>   BUILDBOT_REVISION=dfd9808b6cea59ff075498ee7e6e57f2b5b3a798
>   BUILDBOT_SCHEDULER=main:clang,compiler-rt,lld,llvm
>   CLINK_DIR=C:\Program Files (x86)\clink\0.4.8
>   COMMONPROGRAMFILES=C:\Program Files (x86)\Common Files
>   COMMONPROGRAMFILES(X86)=C:\Program Files (x86)\Common Files
>   COMMONPROGRAMW6432=C:\Program Files\Common Files
>   COMPUTERNAME=WINDOWS-ASAN3
>   COMSPEC=C:\windows\system32\cmd.exe
>   FP_NO_HOST_CHECK=NO
>   LOCALAPPDATA=C:\Users\buildbot\AppData\Local
>   NUMBER_OF_PROCESSORS=16
>   OS=Windows_NT
>   PATH=C:\Program Files\CMake\bin\;C:\Python39\;C:\Python39\Scripts;C:\windows\system32;C:\windows;C:\windows\System32\Wbem;C:\windows\System32\WindowsPowerShell\v1.0\;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\bin;C:\Program Files\Google\Compute Engine\sysprep\;C:\Program Files\Google\Compute Engine\metadata_scripts\;C:\Program Files\TortoiseSVN\bin;C:\gnuwin32\bin;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit\;C:\Program Files\Git\cmd
>   PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC
>   PROCESSOR_ARCHITECTURE=x86
>   PROCESSOR_ARCHITEW6432=AMD64
>   PROCESSOR_IDENTIFIER=Intel64 Family 6 Model 63 Stepping 0, GenuineIntel
>   PROCESSOR_LEVEL=6
>   PROCESSOR_REVISION=3f00
>   PROGRAMDATA=C:\ProgramData
>   PROGRAMFILES=C:\Program Files (x86)
>   PROGRAMFILES(X86)=C:\Program Files (x86)
>   PROGRAMW6432=C:\Program Files
>   PSMODULEPATH=%ProgramFiles(x86)%\WindowsPowerShell\Modules;C:\windows\system32\WindowsPowerShell\v1.0\Modules;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\platform\GoogleCloudPowerShell
>   PUBLIC=C:\Users\Public
>   PWD=C:\b\slave\sanitizer-windows\build
>   SYSTEMDRIVE=C:
>   SYSTEMROOT=C:\windows
>   TEMP=C:\Users\buildbot\AppData\Local\Temp
>   TERM=dumb
>   TMP=C:\Users\buildbot\AppData\Local\Temp
>   USERDOMAIN=WINDOWS-ASAN3
>   USERNAME=buildbot
>   USERPROFILE=C:\Users\buildbot
>   VS140COMNTOOLS=C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\
>   WINDIR=C:\windows
>  using PTY: False
> Step 8 (stage 1 check) failure: stage 1 check (failure)
> ...
> [110/114] Running Fuzzer unit tests
> -- Testing: 55 tests, 16 workers --
> Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
>
> Testing Time: 0.45s
>   Passed: 55
> [111/114] Running the AddressSanitizer tests with dynamic runtime
> llvm-lit.py: C:\b\slave\sanitizer-windows\llvm-project\compiler-rt\test\asan\lit.cfg.py:139: warning: %shared_libasan substitution not set but dynamic ASan is available.
> -- Testing: 634 tests, 16 workers --
> Testing:  0.. 10.. 20.
> FAIL: AddressSanitizer-x86_64-windows-dynamic :: TestCases/Windows/recalloc_sanity.cpp (34 of 634)
> ******************** TEST 'AddressSanitizer-x86_64-windows-dynamic :: TestCases/Windows/recalloc_sanity.cpp' FAILED ********************
> Script:
> --
> : 'RUN: at line 1';      C:/b/slave/sanitizer-windows/build/stage1/./bin/clang-cl.exe  -fsanitize=address -Wno-deprecated-declarations -WX -D_HAS_EXCEPTIONS=0 -Zi     -MD C:\b\slave\sanitizer-windows\llvm-project\compiler-rt\test\asan\TestCases\Windows\recalloc_sanity.cpp -o C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\asan\X86_64WindowsDynamicConfig\TestCases\Windows\Output\recalloc_sanity.cpp.tmp.exe
> : 'RUN: at line 2';    C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\asan\X86_64WindowsDynamicConfig\TestCases\Windows\Output\recalloc_sanity.cpp.tmp.exe 2>&1 | FileCheck C:\b\slave\sanitizer-windows\llvm-project\compiler-rt\test\asan\TestCases\Windows\recalloc_sanity.cpp
> : 'RUN: at line 3';      C:/b/slave/sanitizer-windows/build/stage1/./bin/clang-cl.exe  -Wno-deprecated-declarations -WX -D_HAS_EXCEPTIONS=0 -Zi     C:\b\slave\sanitizer-windows\llvm-project\compiler-rt\test\asan\TestCases\Windows\recalloc_sanity.cpp -o C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\asan\X86_64WindowsDynamicConfig\TestCases\Windows\Output\recalloc_sanity.cpp.tmp.exe
> : 'RUN: at line 4';    C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\asan\X86_64WindowsDynamicConfig\TestCases\Windows\Output\recalloc_sanity.cpp.tmp.exe 2>&1 | FileCheck C:\b\slave\sanitizer-windows\llvm-project\compiler-rt\test\asan\TestCases\Windows\recalloc_sanity.cpp
> --
> Exit Code: 1318
>
> Command Output (stdout):
> --
> $ ":" "RUN: at line 1"
> $ "C:/b/slave/sanitizer-windows/build/stage1/./bin/clang-cl.exe" "-fsanitize=address" "-Wno-deprecated-declarations" "-WX" "-D_HAS_EXCEPTIONS=0" "-Zi" "-MD" "C:\b\slave\sanitizer-windows\llvm-project\compiler-rt\test\asan\TestCases\Windows\recalloc_sanity.cpp" "-o" "C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\test\asan\X86_64WindowsDynamicConfig\TestCases\Windows\Output\recalloc_sanity.cpp.tmp.exe"
> # command output:
> LINK : fatal error LNK1318: Unexpected PDB error; FORMAT (11) ''
>
>
> # command stderr:
> clang-cl: error: linker command failed with exit code 1318 (use -v to see invocation)
>
>
> error: command failed with exit status: 1318
>
> --
>
> ********************
> Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
> ********************
> Failed Tests (1):
>   AddressSanitizer-x86_64-windows-dynamic :: TestCases/Windows/recalloc_sanity.cpp
>
>
> Testing Time: 68.84s
>   Unsupported      : 231
>   Passed           : 384
>   Expectedly Failed:  18
>   Failed           :   1
>
> Sincerely,
> LLVM Buildbot
>