[llvm-dev] AddDiscriminatorsPass not in O0 pipeline under NPM

[via llvm-dev]

Thanks. Sent https://reviews.llvm.org/D105650.

________________________________________
From: Arthur Eubanks <aeubanks at google.com>
Sent: Thursday, July 8, 2021 11:04 AM
To: Chen, Yuanfang
Cc: llvm-dev at lists.llvm.org
Subject: Re: [llvm-dev] AddDiscriminatorsPass not in O0 pipeline under NPM

That's probably not an intentional difference, if you'd like to add that to the NPM feel free to send out a patch.

On Thu, Jul 8, 2021 at 11:54 AM via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote:
Hi,

It seems that, under NPM, AddDiscriminatorsPass is not added into the O0 pipeline (buildO0DefaultPipeline). However, for legacy PM, the pass is in the O0 pipeline (need to specify -fdebug-info-for-profiling). It is hard to tell if it is intentional (https://reviews.llvm.org/D36040<https://urldefense.com/v3/__https://reviews.llvm.org/D36040__;!!JmoZiZGBv3RvKRSx!rwZ2lpd3sVChsIUz67ks0PbVijWl_GGdP9sPEMgsqdaWn58ET9WQW9qAFjyOM_q2Xg$>). So my question is does it make sense to support such configuration (for parity with legacy PM and completeness) or we leave it as is? Any specific use cases for that?

-thanks
Yuanfang
_______________________________________________
LLVM Developers mailing list
llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<https://urldefense.com/v3/__https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev__;!!JmoZiZGBv3RvKRSx!rwZ2lpd3sVChsIUz67ks0PbVijWl_GGdP9sPEMgsqdaWn58ET9WQW9qAFjw_B2Hqpw$>