[llvm-dev] [cfe-dev] RFC: Update LLVM_VERSION_SUFFIX CMake variable for release candidates

[Harald van Dijk via llvm-dev]

On 01/07/2021 17:52, Ben Boeckel wrote:
> On Thu, Jul 01, 2021 at 17:18:04 +0100, Harald van Dijk via cfe-dev wrote:
>> I was working on changing my own testing procedures for my own system to
>> handle the current release candidate structure, where I am in much the
>> same boat as distros, except on a smaller scale. Currently,
>> llvm-12.0.0rc5.src.tar.xz and llvm-12.0.0.src.tar.xz are different
>> files, but the only difference is that the former extracts to an
>> llvm-12.0.0rc5.src directory whereas the latter extracts to a
>> llvm-12.0.0.src directory, the archives are otherwise 100% identical,
> 
> How can it be; isn't at least the embedded `LLVM_VERSION_SUFFIX`
> different? Or am I confused at how `LLVM_VERSION_SUFFIX` is encoded into
> the build today?

Currently, LLVM_VERSION_SUFFIX is cleared on release branches, which 
happens before the first release candidate, and it remains cleared once 
the release happens. See commit 7051e794 for when this was done for the 
12.x branch. So llvm-12.0.0rc5.src/CMakeLists.txt contains:

if(NOT DEFINED LLVM_VERSION_SUFFIX)
   set(LLVM_VERSION_SUFFIX "")
endif()

And this remained the same in llvm-12.0.0.src/CMakeLists.txt.

Cheers,
Harald van Dijk