[llvm-dev] a mistake in my commit

[Florian Hahn via llvm-dev]

Hi,

> On Jan 6, 2021, at 10:57, Ben Shi via llvm-dev <llvm-dev at lists.llvm.org> wrote:
> 
> I made a commit https://github.com/llvm/llvm-project/commit/351a45ca73de3ec4524d2194674e2a92f8b7d9b5 <https://github.com/llvm/llvm-project/commit/351a45ca73de3ec4524d2194674e2a92f8b7d9b5>
> 
> but forget to attach the review message, https://reviews.llvm.org/D94062 <https://reviews.llvm.org/D94062>
> 
> What can I do to fix it?

I think the only thing you could do is reverting the original commit and re-commit with the commit message you want.

But it looks like the commit just adds a few new tests and the review has an empty description anyways. So I assume the main thing missing is `Differential Revision: xxxx` to auto-close the review? In that case, that doesn’t sound like a big deal to me personally and I would just manually close the review in Phabricator with a link to the commit (there’s a ‘Close Revision’ action in the drop-down above the comment form)

Cheers,
Florian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210106/668199d8/attachment.html>