[llvm-dev] Anyone doing code reviews via mailing lists?
Martin Storsjö via llvm-dev
llvm-dev at lists.llvm.org
Fri Apr 23 13:43:37 PDT 2021
On Fri, 23 Apr 2021, Renato Golin via llvm-dev wrote:
> Yeah, I can't remember the last time I did a review by email. But I'm sure
> that they were replies to a commit that broke our bots, and not an actual
> review of a pull request.
> Worse, I think if someone does a review by email and doesn't copy me
> directly, I won't even notice.
Especially for cases where a commit didn't go through review on
Phabricator, it's probably common to react to it via e.g. a reply to the
commit mail, as it both goes to the list and hopefully reaches the author
that way.
// Martin
More information about the llvm-dev
mailing list