[llvm-dev] clang-tidy makes review a pain

[Shivam Gupta via llvm-dev]

"Shift + A" can be used to hide all inline comments.


From: Maxim Kazantsev via llvm-dev <llvm-dev at lists.llvm.org>
Sent: Mon, 19 Apr 2021 15:13:38 GMT+0530
To: "llvm-dev at lists.llvm.org" <llvm-dev at lists.llvm.org>
Subject: [llvm-dev] clang-tidy makes review a pain






 


Hello everyone,
 
I started noticing that lately we’ve improved reporting from clang-tidy, pointing out at various formatting issues. However the more verbose it becomes, the more annoyed I feel about it. For example here:
 
https://reviews.llvm.org/D100721
 
It complains literally about every second line, inserting its comments straight into review. They take as much space as the actual code. Maybe it’s just me, but it’s really hard to me to understand what the patch is actually
 doing with so many inlined auto-generated comments. Maybe there is a button to hide them somewhere, but I failed to find it.
 
I understand what was the intention, and clang-tidy is a cool thing in general, but it’s getting too intrusive. Does anyone else have the same problem as I do? If there’s a lot of people whom it annoys, maybe we should
 think how to make it less invasive. Maybe it should put these comment when the patch gets approved, or something like this.
 
Thanks,
Max
 

 
 
_______________________________________________

LLVM Developers mailing list

llvm-dev at lists.llvm.org

https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210419/0fe1faea/attachment.html>