[llvm-dev] Manipulating DAGs in TableGen

[Nicolai Hähnle via llvm-dev]

On 19.10.20 19:33, Paul C. Anagnostopoulos wrote:
> But aren't we concerned about users of TableGen outside of the LLVM project? I've come across at least one in my travels through the interwebs.

True, it's fair to give them a heads-up. Depending on the user, it may 
already be good enough to split the change up into two: first, a chancge 
to add !getdagop/!setdagop; second, a change to remove the old form. 
That provides at least one "moment in time" where both versions can be 
used, which can help with migrations.

If you leave a few weeks between committing the two changes, it's even 
nicer.

Cheers,
Nicolai


> 
> At 10/19/2020 01:25 PM, Nicolai Hähnle wrote:
>> On 19.10.20 18:53, Paul C. Anagnostopoulos wrote:
>>> I think I will do both. In order that dag(i) can work and fetch the operator, an integer index is needed for it. So -1 for the operator. Then that should be supported in the other bang operators.
>>> Meanwhile, I will rename !getdagop and !setdagop just for consistency. The old !getop and !setop will remain, of course, but deprecated. !getop is used 0 times and !setop 4 times.
>>
>> If it's really only used 4 times, it may be worth just removing those instances instead of keeping the deprecated versions around.
>>
>> Cheers,
>> Nicolai
> 

-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.