[llvm-dev] Phabricator new review email behaviour change?

[Jay Foad via llvm-dev]

I'm not sure if this is the same issue, but a few times recently I've
noticed an upstream review that seems not to have generated any
notification emails to llvm-commits.

https://reviews.llvm.org/D89501 is an example. There is no record of it
either in
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20201012/subject.html
or in my own email archive.

Does anyone know what happened?

Thanks,
Jay.

On Tue, 1 Sep 2020 at 11:11, James Henderson via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> The issue seems to have been resolved, in that newer patches are indeed
> coming from Phabricator again, but there was a period of a few days when it
> stopped working. For example, I never received a reviews.llvm.org email
> for the creation of the patch D86350, but did for follow-up comments. It
> did appear in my llvm-commits folder, sent via the llvm-commits mailing
> list, but since I didn't have the version from Phabricator, my
> from:reviews at reviews.llvm.org filter didn't spot it, and it got filtered
> away.
>
> On Thu, 27 Aug 2020 at 18:33, Fāng-ruì Sòng <maskray at google.com> wrote:
>
>> Hi James,
>>
>> Seems that `from:reviews at reviews.llvm.org` can still retrieve messages
>> related to Phabricator notifications (new differentials by yourself,
>> new differentials by others for which you subscribe, and commits
>> associated to differentials you subscribe). Do you have more
>> information about the anomaly you observed?
>>
>> For example, from a message I received 4 days ago:
>>
>> Content-Type: multipart/mixed;
>> boundary=3744cde2fafc2e1ab0b2e19da34774d501999ac79b12974f54ed8afbc945
>> Date: Sun, 23 Aug 2020 18:33:29 +0000 (UTC)
>> From: Fangrui Song via Phabricator <reviews at reviews.llvm.org>
>> Mime-Version: 1.0
>> Message-ID: <ycGDVmhWTWa_D3F1wF92qA at ismtpd0007p1iad2.sendgrid.net>
>> Thread-Topic: PHID-DREV-hd6ds2iug53idmfbdqxk
>>
>> I think a rule matching from:reviews at reviews.llvm.org should work.
>>
>> On Thu, Aug 27, 2020 at 1:12 AM James Henderson
>> <jh7370.2008 at my.bristol.ac.uk> wrote:
>> >
>> > Hi,
>> >
>> > Is it me, or has Phabricator changed at some point in the past week or
>> two with regards to emails for newly created reviews? I noticed this
>> morning that my mailing rule (which previously simply marked new emails
>> from review at reviews.llvm.org with a specific tag) was no longer working
>> for them, and consequently, I missed several new review requests. (It
>> wasn't an issue for subsequent emails for the same review, for the record).
>> I _think_ I've come up with a new rule for the current behaviour, but it
>> was concerning because I expect I'm not the only one who is in that boat.
>> >
>> > Flagging it up in case it was an accident and/or so that people know of
>> the behaviour change.
>> >
>> > Thanks,
>> >
>> > James
>>
>>
>>
>> --
>> 宋方睿
>>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20201016/c0afe873/attachment.html>