[llvm-dev] RFC: Combining Annotation Metadata and Remarks
Florian Hahn via llvm-dev
llvm-dev at lists.llvm.org
Thu Nov 12 08:50:55 PST 2020
> On Nov 10, 2020, at 22:09, Florian Hahn via llvm-dev <llvm-dev at lists.llvm.org> wrote:
>> On Nov 9, 2020, at 19:27, Johannes Doerfert <johannesdoerfert at gmail.com <mailto:johannesdoerfert at gmail.com>> wrote:
>> On 11/9/20 5:09 AM, Florian Hahn wrote:
>>> I think Francis already took a look at some passes that would need updating when annotating auto-init stores. Most of the problematic transforms (like SROA, LoopIdiom and InstCombine) are combining stores to stores of wider types or various mem* intrinsics. As an initial general rule, it probably makes sense to preserve any annotation metadata, if all combined instructions share the same metadata?
>> Keeping identical annotation, sure. Otherwise, the pass should call the helper API and define what kind of transformation was performed to get the proper set of annotations back.
>>> I think it would make sense to start with something like that and then go from there and iterate once there once we have concrete use cases that need more specialized rules. What do you think?
>> I'm all for it. Also, the things I mention here don't need to be part of the first patch (set), just something to keep in mind.
> Sounds good. For now, I split up the original WIP patch (https://reviews.llvm.org/D89240 <https://reviews.llvm.org/D89240>) into two separate ones:
> 1. Add !annotation metadata and AnnotationRemarks generation https://reviews.llvm.org/D91188 <https://reviews.llvm.org/D91188>2. __attribute__((annotate(“”) to !annotate metadata conversion https://reviews.llvm.org/D91195 <https://reviews.llvm.org/D91195>
It sounds like there are no concerns or objections for this approach and the review for adding the !annotation metadata (https://reviews.llvm.org/D91188 <https://reviews.llvm.org/D91188>) is moving along nicely. Please let me know if there are any remaining concerns or points we should discuss further. If not, I am planning on submitting the change tomorrow or early next week.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev