[llvm-dev] GSoC 2020 Project "Improve MegreFunctions to incorporate MergeSimilarFunctions patches and ThinLTO Support"
Aditya K via llvm-dev
llvm-dev at lists.llvm.org
Sat Mar 21 11:24:51 PDT 2020
This was the starter assignment for the students to merge the patches.
We'll address the comments from the original patches once the intern has been finalized.
JF Bastien has agreed to co-mentor the project, we'll try to address the core issues to make merge-function as robust as possible.
From: Teresa Johnson <tejohnson at google.com>
Sent: Friday, March 20, 2020 1:42 PM
To: Aditya K <hiraditya at msn.com>; JF Bastien <jfbastien at apple.com>
Cc: llvm-dev <llvm-dev at lists.llvm.org>; chebroluvishal at gmail.com <chebroluvishal at gmail.com>; ruijief at princeton.edu <ruijief at princeton.edu>
Subject: Re: [llvm-dev] GSoC 2020 Project "Improve MegreFunctions to incorporate MergeSimilarFunctions patches and ThinLTO Support"
Hi all, I see there are a lot of new patches being produced to merge various combinations of the original patches together and rebase with head. I just added myself a reviewer to the ones I saw. A couple high level comments: These various mergings
of the patches together don't need to all be separate patches in Phabricator. Really only whatever you want reviewed by the community needs to go up on Phabricator, which is presumably the final merged and rebase patch. Also, please keep all the original
reviewers on the new patch(es). There are a number of comments on the original patches that still need to be resolved fyi, so please take a look at those before proceeding too far. +JF
Bastien who also commented to that effect. It might be good to coordinate your efforts as well.
More information about the llvm-dev