[llvm-dev] [cfe-dev] Phabricator Maintenance

[Hubert Tong via llvm-dev]

On Fri, Jun 19, 2020 at 7:32 PM David Blaikie via cfe-dev <
cfe-dev at lists.llvm.org> wrote:

> On Fri, Jun 19, 2020 at 4:23 PM Zachary Turner via llvm-dev
> <llvm-dev at lists.llvm.org> wrote:
> >
> > I use GH daily at my current employer and i can tell you that the issues
> with rebasing are very real.  Unless you only use merge commits you are
> going to have a very bad time
>
> Would it be practical to use merge commits during review (never
> rebasing) & then rebasing/squashing to commit to the main line?
> (guessing that might still make looking back at the history of the
> review difficult?)
>
A merge appears in the UI as introducing many, many commits. Also, a key
method of progressing reviews on Phabricator (for me) is to go through the
differences between the updates. If there is a merge in between on GitHub,
I don't want to see all the changes that come from the merged commits.


>
> - Dave
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200619/5214802c/attachment-0001.html>